From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: [PATCH] [xm] Fix vncdisplay for hvm guests Date: Tue, 15 May 2007 17:14:25 -0600 Message-ID: <464A3ED1.1010904@novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------030005020708070502000405" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------030005020708070502000405 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit 'vncdisplay=N' in hvm config file is ignored when building qemu-dm arguments. xm create or xm new -> xm start with hvm config file containing vnc=1 vncdisplay=5 results in '-vncunused' being passed to qemu-dm. There are several approaches for a fix - this patch defaults vncdisplay to None in xm options. It currently defaults to 1 and is always included in the image config created by configure_hvm() in tools/python/xen/xm/create.py. In xend (tools/python/xen/xend/image.py - parseDeviceModelArgs), vncunused takes precedence over vncdisplay. This patch is against 3.1.0-testing but looks like problem exists in unstable as well - even with recent changes to tools/python/xen/xend/image.py when moving to qemu 0.9.0 Regards, Jim --------------030005020708070502000405 Content-Type: text/x-patch; name="xm-vncunused.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="xm-vncunused.patch" # HG changeset patch # User Jim Fehlig # Date 1179270277 21600 # Node ID b6a56d49c45c7ae82851e04e6322f18aa6e2c481 # Parent aee991c7723a0c2fb88811c7c8b3cbdcb89f2bb9 'vncdisplay=N' in hvm config file is ignored when building qemu-dm arguments. xm create or xm new -> xm start with hvm config file containing vnc=1 vncdisplay=5 results in '-vncunused' being passed to qemu-dm. There are several approaches for a fix - this patch defaults vncdisplay to None in xm options. Signed-off-by: Jim Fehlig diff -r aee991c7723a -r b6a56d49c45c tools/python/xen/xm/create.py --- a/tools/python/xen/xm/create.py Wed May 09 16:34:47 2007 +0100 +++ b/tools/python/xen/xm/create.py Tue May 15 17:04:37 2007 -0600 @@ -474,7 +474,7 @@ gopts.var('vnclisten', val='', use="""Address for VNC server to listen on.""") gopts.var('vncunused', val='', - fn=set_bool, default=1, + fn=set_bool, default=None, use="""Try to find an unused port for the VNC server. Only valid when vnc=1.""") --------------030005020708070502000405 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------030005020708070502000405--