Re: [PATCH 2/2] AFS: Implement shared-writable mmap

[Nick Piggin <nickpiggin@yahoo.com.au>]

Christoph Hellwig wrote:
> On Tue, May 15, 2007 at 04:52:31PM +0100, David Howells wrote:
> 
>>+int afs_page_mkwrite(struct vm_area_struct *vma, struct page *page)
>>+{
>>+	struct afs_vnode *vnode = AFS_FS_I(vma->vm_file->f_mapping->host);
>>+	struct key *key = vma->vm_file->private_data;
>>+	int ret;
>>+
>>+	_enter("{{%x:%u},%x},{%lx}",
>>+	       vnode->fid.vid, vnode->fid.vnode, key_serial(key), page->index);
>>+
>>+	lock_page(page);
>>+	ret = afs_prepare_write(vma->vm_file, page, 0, 0);
>>+	unlock_page(page);
>>+
>>+	_leave(" = %d", ret);
>>+	return ret;
>>+}
> 
> 
> It looks like you really want Dave's generic page_mkwrite.

Is that appropriate for a non buffer based filesystem?


> And we should
> really get that one merged for 2.6.22.

Dave asked me about that the other day (in relation to the ->fault ops)...
I have no problem merging it for 2.6.22 and rebasing my patches on top.

-- 
SUSE Labs, Novell Inc.