Re: Ignore the cdecl and stdcall attributes for now.

[Michael Stefaniuc <mstefani@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1684 bytes --]

Josh Triplett wrote:
> Michael Stefaniuc wrote:
>> Wine uses the __stdcall__ attribute extensively. The effects of the
>> patch on a sparse run on the Wine code are:
>> - Removes 143000 "attribute '__stdcall__': unknown attribute" errors.
>> - Removes 116 "attribute '__cdecl__': unknown attribute" errors.
>> - Reduces the amount of "error: too many errors" from 1992 to 1459.
>>
>> Signed-off-by: Michael Stefaniuc <mstefani@redhat.com>
> 
> Applied, along with a test case.  Thanks!
Thanks.

> I'd love to see the results you get with Wine; in particular, I'd love to see
> and fix any parse errors.  Would you consider posting a build log somewhere
I thankfully accept your offer :)

> with latest Sparse from Git?
The output is still big. But i have a test case for the next big problem 
generator in Wine. It's attached as a git patch to 
validate/calling-convention-attributes.c (I can send it separately to 
the linux-sparse mailing list if you want). Sparse gives:
calling-convention-attributes.c:7:12: error: Expected ; at end of 
declaration
calling-convention-attributes.c:7:12: error: got f5ptr

> Did you integrate Sparse into the Wine build system, or did you use CC=cgcc?
Crude hack in my git tree to Make.rules adding a sparse call to the .c 
=> .o build rule. Tried to see how the Kernel build system integrates 
that and my  head started to smoke ... . I do not plan to send it 
upstream for the moment.

bye
	michael
-- 
Michael Stefaniuc               Tel.: +49-711-96437-199
Sr. Network Engineer            Fax.: +49-711-96437-111
Red Hat GmbH                    Email: mstefani@redhat.com
Hauptstaetterstr. 58            http://www.redhat.de/
D-70178 Stuttgart

[-- Attachment #2: 0001-Add-test-for-typedef-on-pointer-to-function-with-std.patch --]
[-- Type: text/x-patch, Size: 937 bytes --]

From a31ddd057217701c239677f820fa4bb5456ab079 Mon Sep 17 00:00:00 2001
From: Michael Stefaniuc <mstefani@redhat.com>
Date: Wed, 16 May 2007 13:12:42 +0200
Subject: [PATCH] Add test for typedef on pointer to function with stdcall attribute.


Signed-off-by: Michael Stefaniuc <mstefani@redhat.com>
---
 validation/calling-convention-attributes.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/validation/calling-convention-attributes.c b/validation/calling-convention-attributes.c
index 0546754..1bbe575 100644
--- a/validation/calling-convention-attributes.c
+++ b/validation/calling-convention-attributes.c
@@ -2,3 +2,6 @@ extern void __attribute__((cdecl)) f1(void);
 extern void __attribute__((__cdecl__)) f2(void);
 extern void __attribute__((stdcall)) f3(void);
 extern void __attribute__((__stdcall__)) f4(void);
+
+typedef void (__attribute__((__stdcall__)) *f5)(void);
+typedef f5 f5ptr;
-- 
1.5.0.6