From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Johann Lombardi <johann@clusterfs.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: Clear PG_error before reading a page
Date: Thu, 17 May 2007 01:49:06 +1000 [thread overview]
Message-ID: <464B27F2.90806@yahoo.com.au> (raw)
In-Reply-To: <20070516153919.GC2630@chiva>
Johann Lombardi wrote:
> On Tue, May 15, 2007 at 02:23:39PM -0700, Andrew Morton wrote:
>>If get_block() failed then we don't know what blocks to read to
>>bring this page uptodate, so the pagecache page should remain in state
>>!PageUptodate(), !PageError(). But then, we shouldn't have populated
>>pagecache at that offset at all.
>
>
> Yes, indeed. do_generic_mapping_read() doesn't populate the pagecache if an
> error occurred.
> Still, __do_page_cache_readahead()->read_pages()->ext3_readpages()->mpage_readpages()
> does populate the pagecache even if the page reads failed.
Doesn't really matter. If the read failed then the page is not uptodate.
If it didn't, then it isn't error.
--
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2007-05-16 15:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 14:37 Clear PG_error before reading a page Johann Lombardi
2007-05-15 17:11 ` Andrew Morton
2007-05-15 21:01 ` Johann Lombardi
2007-05-15 21:23 ` Andrew Morton
2007-05-16 15:39 ` Johann Lombardi
2007-05-16 15:49 ` Nick Piggin [this message]
2007-05-16 16:12 ` Andrew Morton
2007-05-17 11:42 ` Johann Lombardi
2007-05-17 16:47 ` Andrew Morton
2007-05-29 17:06 ` Johann Lombardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464B27F2.90806@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@linux-foundation.org \
--cc=johann@clusterfs.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.