All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christian <haveaniceday@cv-sv.de>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.22-rc1 does not boot on VIA C3_2 cause of X86_CMPXCHG64
Date: Wed, 16 May 2007 21:51:36 -0700	[thread overview]
Message-ID: <464BDF58.2090907@zytor.com> (raw)
In-Reply-To: <alpine.LFD.0.98.0705162012340.3890@woody.linux-foundation.org>

Linus Torvalds wrote:
> 
> On Wed, 16 May 2007, H. Peter Anvin wrote:
>> It gets turned on by the code in arch/i386/kernel/cpu.  It's just that
>> the new code that Andi added runs during setup, i.e. in real mode, so
>> *way* earlier than that.
> 
> Ahh. Do we really need it that early?

The reason to do it early is so that we can still get a message out if
the CPU doesn't have the necessary features.  This is generic code and
not specific to CX8.

Since I'm rewriting the setup code in C, I have added code to enable
features on VIA and Transmeta CPUs (there was already code in there to
enable features on AMD; Intel isn't known to hide any features other
than PAE on 400 MHz FSB Pentium-M.)

I think the early feature detection makes good sense.  It's a heckuva
lot nicer to get a message on your screen saying that you can't boot
this kernel on this CPU than a crash, or an early_printk which may never
actually get to you.

	-hpa

  reply	other threads:[~2007-05-17  4:52 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-17  0:09 2.6.22-rc1 does not boot on VIA C3_2 cause of X86_CMPXCHG64 Christian
2007-05-17  0:42 ` Dave Jones
2007-05-17  1:15   ` H. Peter Anvin
2007-05-17  1:55     ` H. Peter Anvin
2007-05-17  1:39   ` Christian
2007-05-17 21:28     ` Christian Volkmann
2007-05-17 21:47       ` Dave Jones
2007-05-17 21:59         ` Christian Volkmann
2007-05-31  5:22         ` [RFC: 2.6 patch] i386: remove support for the Rise CPU Adrian Bunk
2007-05-31 13:31           ` Dave Jones
2007-05-31 17:37             ` Christian Volkmann
2007-05-31 17:48               ` Dave Jones
2007-05-19 10:22       ` 2.6.22-rc1 does not boot on VIA C3_2 cause of X86_CMPXCHG64 Hans de Bruin
2007-05-17  8:56   ` Alan Cox
2007-05-17 11:51   ` Andi Kleen
2007-05-17 15:02     ` Dave Jones
2007-05-17 22:14     ` H. Peter Anvin
2007-05-19  5:53   ` 2.6.22-rc1 does not boot on VIA C3_2 cause of X86_CMPXCHG64 II Andi Kleen
2007-05-19  6:02     ` Dave Jones
2007-05-19 11:47       ` Andi Kleen
2007-05-19 17:23         ` Dave Jones
2007-05-19  8:22     ` Claas Langbehn
2007-05-19 18:10       ` H. Peter Anvin
2007-05-19 11:42     ` Christian Volkmann
2007-05-19 11:54       ` Andi Kleen
2007-05-23 21:50         ` H. Peter Anvin
2007-05-19 17:26       ` Claas Langbehn
2007-05-19 20:22         ` Via C3: other flags possible ? Christian Volkmann
2007-05-19 22:36           ` Christian Volkmann
2007-05-19 22:52             ` Via C3/C7: " Simon Arlott
2007-05-20  8:19               ` Claas Langbehn
2007-05-20 13:14                 ` Christian Volkmann
2007-05-20 12:59             ` Via C3: " Andi Kleen
2007-05-19 17:54       ` 2.6.22-rc1 does not boot on VIA C3_2 cause of X86_CMPXCHG64 II Claas Langbehn
2007-05-17  1:10 ` 2.6.22-rc1 does not boot on VIA C3_2 cause of X86_CMPXCHG64 Linus Torvalds
2007-05-17  1:25   ` Christian
2007-05-17  2:21     ` Linus Torvalds
2007-05-17  3:05       ` H. Peter Anvin
2007-05-17  3:16         ` Linus Torvalds
2007-05-17  4:51           ` H. Peter Anvin [this message]
2007-05-17  6:18             ` Dave Jones
2007-05-17  6:31               ` H. Peter Anvin
2007-05-17  6:17           ` Dave Jones
2007-05-17  9:22 ` Hans de Bruin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=464BDF58.2090907@zytor.com \
    --to=hpa@zytor.com \
    --cc=haveaniceday@cv-sv.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.