All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Jones <pjones@redhat.com>
To: Dave Jones <davej@redhat.com>, Matthew Wilcox <matthew@wil.cx>,
	Benjamin LaHaise <bcrl@kvack.org>,
	James Bottomley <james.bottomley@steeleye.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-scsi@vger.kernel.org, kernel-packagers@vger.kernel.org,
	pjones@redhat.com
Subject: Re: Asynchronous scsi scanning
Date: Thu, 17 May 2007 18:00:50 -0400	[thread overview]
Message-ID: <464CD092.6050300@redhat.com> (raw)
In-Reply-To: <20070517214234.GA398@redhat.com>

Dave Jones wrote:
> On Thu, May 17, 2007 at 03:30:43PM -0600, Matthew Wilcox wrote:
>  > On Thu, May 17, 2007 at 03:43:26PM -0400, Benjamin LaHaise wrote:
>  > > On Thu, May 17, 2007 at 01:39:54PM -0600, Matthew Wilcox wrote:
>  > > > On Fri, May 18, 2007 at 12:34:40AM +0530, Satyam Sharma wrote:
>  > > > > Hmmm, actually those other users could easily write and maintain
>  > > > > a 20-line patch that does the wait for async scans thing for them
>  > > > > using /proc/scsi/scsi in any case.

This is one of the things we currently do.  There are problems with it, 
not the least of which being that it's hard to know how long to wait, 
and waiting excessively long generates user complaints.

>  > > > How about the three users who're bothered by this extra module being
>  > > > built maintain a one-line patch to Kconfig and leave well enough alone?

(I assume this is about scsi_wait_scan)

>  > > The module has an added bonus that it doesn't require any new tools to 
>  > > make work.  Doing it via sysfs/procfs means a new rev of whatever tool 
>  > > generates the boot initrd, plus fixing up boot scripts.  Loading a module 
>  > > can be done via a simple option to the existing boot tools.

This isn't really true -- loading the module requires that a user is 
actually running the tools and knows to do it, which is rarely (and 
ideally never) the case.  And frankly, every single one of our users 
would have to do it.

So really, either way means we need to update the tools.  It also 
doesn't really solve the problem -- when I insert "usb-storage", the 
SCSI scan may still finish while we're still enumerating the bus for USB 
devices. (I'd be willing to believe I'm wrong about this specific 
example, but I suspect the principle still applies for some other driver.)

In practice, we wind up doing the compare/timeout loop as on 
/proc/scsi/scsi, but on /proc/bus/usb/devices or 
/sys/bus/ieee1394/drivers/sbp2 instead.

>  > That was what James and I thought.  However, the distros seem unhappy
>  > with it.  Of course, they won't actually *comment* on it, they just
>  > disable the async scan and won't talk about why.
> 
> FWIW, Fedora 7 has it enabled, and afaik, Peter (mkinitrd maintainer) is happy
> with the current situation.  It's my understanding that the latest ubuntu
> release has it enabled too, though obviously I can't speak for whether
> or not they're happy with the status quo.

I wouldn't say I'm *happy* with the current situation, but we're to the 
point where it works for most users.

At the same time, we're moving towards polling on the hotplug socket, 
waiting for specific devices to appear from which to build and mount 
"/".  That should obviate the need for much of this in most cases.

-- 
   Peter

  reply	other threads:[~2007-05-17 22:00 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-13 15:22 why does x86 "make defconfig" build a single, lonely module? Robert P. J. Day
2007-05-13 15:58 ` Jan Engelhardt
2007-05-13 16:06 ` Dave Jones
2007-05-13 16:10   ` James Bottomley
2007-05-13 16:18     ` James Bottomley
2007-05-13 16:30       ` Dave Jones
2007-05-14  9:35       ` Satyam Sharma
2007-05-14  9:45         ` Satyam Sharma
2007-05-14 12:00           ` Satyam Sharma
2007-05-14 12:23             ` Satyam Sharma
2007-05-14 14:31               ` James Bottomley
2007-05-15  0:41                 ` Satyam Sharma
2007-05-15 11:26                   ` Simon Arlott
2007-05-15 12:02                     ` Asynchronous scsi scanning Matthew Wilcox
2007-05-15 16:30                       ` Simon Arlott
2007-05-15 17:29                         ` Matthew Wilcox
2007-05-15 21:56                           ` [PATCH] SCSI: Let users disable SCSI_WAIT_SCAN to be built Stefan Richter
2007-05-16 14:43                             ` Stefan Richter
2007-05-17 14:00                               ` James Bottomley
2007-05-17 17:02                                 ` Satyam Sharma
2007-05-15 23:27                           ` Asynchronous scsi scanning Satyam Sharma
2007-05-15 23:28                             ` Arjan van de Ven
2007-05-15 23:49                               ` Satyam Sharma
2007-05-16  2:51                             ` Matthew Wilcox
2007-05-16  2:59                               ` Roland Dreier
2007-05-17 17:13                               ` Satyam Sharma
2007-05-17 17:20                                 ` Matthew Wilcox
2007-05-17 17:41                                   ` Satyam Sharma
2007-05-17 18:24                                     ` Christoph Hellwig
2007-05-17 18:47                                       ` Satyam Sharma
2007-05-17 18:51                                         ` Christoph Hellwig
2007-05-17 19:04                                           ` Satyam Sharma
2007-05-17 19:39                                             ` Matthew Wilcox
2007-05-17 19:43                                               ` Benjamin LaHaise
2007-05-17 21:30                                                 ` Matthew Wilcox
2007-05-17 21:42                                                   ` Dave Jones
2007-05-17 22:00                                                     ` Peter Jones [this message]
2007-05-18 14:00                                                       ` Stefan Richter
2007-05-18  5:28                                                   ` Satyam Sharma
2007-05-18 11:24                                                     ` Matthew Wilcox
2007-05-18 13:14                                                       ` Satyam Sharma
2007-05-18  3:41                                                 ` Satyam Sharma
2007-05-18 11:19                                                   ` Matthew Wilcox
2007-05-18 13:06                                                     ` Satyam Sharma
2007-05-17 17:32                             ` sysfs makes scaling suck " Benjamin LaHaise
2007-05-17 17:45                               ` James Bottomley
2007-05-17 17:49                                 ` Benjamin LaHaise
2007-05-19 16:30                                   ` Greg KH
2007-05-17 22:24                       ` Peter Jones
2007-05-13 16:20     ` why does x86 "make defconfig" build a single, lonely module? Robert P. J. Day
2007-05-13 16:27       ` James Bottomley
2007-05-13 16:37         ` Robert P. J. Day
2007-05-13 17:42         ` Simon Arlott
2007-05-13 17:48           ` James Bottomley
2007-05-13 18:26             ` Simon Arlott
2007-05-13 18:45               ` Dave Jones
2007-05-13 18:45               ` James Bottomley
2007-05-14 17:29             ` Jan Engelhardt
2007-05-14 18:46               ` Alan Cox
2007-05-14 20:06                 ` Jan Engelhardt
2007-05-13 16:28     ` Dave Jones
2007-05-13 20:38     ` Simon Arlott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=464CD092.6050300@redhat.com \
    --to=pjones@redhat.com \
    --cc=bcrl@kvack.org \
    --cc=davej@redhat.com \
    --cc=james.bottomley@steeleye.com \
    --cc=kernel-packagers@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.