All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Tobias Bengtsson <tobbe@tobbe.nu>
Cc: Philip Langdale <philipl@overt.org>,
	sdhci-devel@list.drzeus.cx, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sdhci: Add quirk to support polling for card presence
Date: Fri, 18 May 2007 01:01:01 +0200	[thread overview]
Message-ID: <464CDEAD.6090106@drzeus.cx> (raw)
In-Reply-To: <46479D59.4020400@overt.org>

Tobias, did you test this patch and did it solve your problem?

Philip Langdale wrote:
> There is apparently at least one instance of the Ricoh SDHCI
> implementation out there where card insertion (and possibly
> removal) interrupts do not work - so the only way to detect
> a change in the presence of a card is to poll.
>
> This changes adds a polling quirk for the particular model
> reported by Tobias. The change is tentative as it assumes
> that removal interrupts do not work, but if they do work,
> then we can optimise things by not polling when there is
> a card present. So, it should not be committed until Tobias
> has confirmed the removal behaviour one way or the other and
> the change is accordingly updated.
>
> The polling frequency is 3 seconds because I've been running
> powertop and am paranoid about wakeups now. :-) I did some
> testing locally by masking out the interrupt events and 3
> seconds seems usable enough to me.
>
> Signed-off-by: Philip Langdale <philipl@overt.org>
>
>   

Rgds

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org


  parent reply	other threads:[~2007-05-17 23:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-13 23:20 [PATCH] sdhci: Add quirk to support polling for card presence Philip Langdale
2007-05-14 10:29 ` Pierre Ossman
2007-05-15  3:21   ` Philip Langdale
2007-05-17 23:01 ` Pierre Ossman [this message]
2007-05-18 10:58   ` Tobias Bengtsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=464CDEAD.6090106@drzeus.cx \
    --to=drzeus-list@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipl@overt.org \
    --cc=sdhci-devel@list.drzeus.cx \
    --cc=tobbe@tobbe.nu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.