From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Tim Valenzuela <tim@deadlyninja.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] sata_via: pcim_iomap_regions() conversion missed BAR5
Date: Thu, 17 May 2007 20:59:07 -0400 [thread overview]
Message-ID: <464CFA5B.3000703@garzik.org> (raw)
In-Reply-To: <464C3E68.30608@gmail.com>
Tejun Heo wrote:
> pcim_iomap_regions() conversion missed BAR5. Fix it.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Sorry, dunno how I missed that during testing. :-( Please verify this
> fixes your problem.
>
> diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
> index d105d2c..ac4f43c 100644
> --- a/drivers/ata/sata_via.c
> +++ b/drivers/ata/sata_via.c
> @@ -441,7 +441,7 @@ static int vt6421_prepare_host(struct pc
> return -ENOMEM;
> }
>
> - rc = pcim_iomap_regions(pdev, 0x1f, DRV_NAME);
> + rc = pcim_iomap_regions(pdev, 0x3f, DRV_NAME);
> if (rc) {
> dev_printk(KERN_ERR, &pdev->dev, "failed to request/iomap "
> "PCI BARs (errno=%d)\n", rc);
applied.
Please figure out a better method than raw hex numbers for the mask...
prev parent reply other threads:[~2007-05-18 0:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 10:09 sata_via, 2.6.22-rc1, VT6421A Tim Valenzuela
2007-05-17 11:37 ` [PATCH] sata_via: pcim_iomap_regions() conversion missed BAR5 Tejun Heo
2007-05-17 13:40 ` Tim Valenzuela
2007-05-17 13:49 ` Tejun Heo
2007-05-17 15:37 ` Tim Valenzuela
2007-05-18 0:59 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464CFA5B.3000703@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=tim@deadlyninja.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.