All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Hecken <dh-LcvzS2Pvy/8X0D0ZMPkEVw@public.gmane.org>
To: avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org,
	eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: 2 Bugs found for compilation on 32 Bit machine
Date: Fri, 18 May 2007 10:30:21 +0200	[thread overview]
Message-ID: <464D641D.1040402@bahntechnik.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

Hello,

I have an Intel Core 2 Duo running Ubuntu Feisty 2.6.20-15 in 32 Bit
mode. If I try to compile kvm-trunk ( kvm-24-gfbfe1dc ) and the modules
from git ( v2.6.22-rc1-gf552bf6 ) I get a few compiler errors and the
compiler stops.

Please find attached 2 patches to fix the errors.

Danie Hecken

[-- Attachment #2: user_test_32bit.patch --]
[-- Type: text/x-diff, Size: 614 bytes --]

--- kvm-trunk_old/user/Makefile	2007-05-17 18:42:35.000000000 +0200
+++ kvm-trunk/user/Makefile	2007-05-18 10:11:30.000000000 +0200
@@ -39,12 +39,11 @@
 libkvm.a: kvmctl.o
 	$(AR) rcs $@ $^
 
-flatfiles-common = test/simple.flat test/stringio.flat test/memtest1.flat \
-	test/bootstrap test/vmexit.flat
+flatfiles-common = test/bootstrap test/vmexit.flat
 
 flatfiles-32 = 
 
-flatfiles-64 = test/access.flat test/irq.flat test/sieve.flat
+flatfiles-64 = test/access.flat test/irq.flat test/sieve.flat test/simple.flat test/stringio.flat test/memtest1.flat
 
 flatfiles: $(flatfiles-common) $(flatfiles-$(bits))
 

[-- Attachment #3: msrs_32bit.patch --]
[-- Type: text/x-diff, Size: 671 bytes --]

--- kvm-trunk_old/kernel/vmx.c	2007-05-17 19:44:10.000000000 +0200
+++ kvm-trunk/kernel/vmx.c	2007-05-18 10:20:08.000000000 +0200
@@ -479,6 +479,7 @@
 	int index, save_nmsrs;
 
 	save_nmsrs = 0;
+#ifdef X86_64
 	if (is_long_mode(vcpu)) {
 		index = __find_msr_index(vcpu, MSR_SYSCALL_MASK);
 		if (index >= 0)
@@ -496,12 +497,11 @@
 		 * MSR_K6_STAR is only needed on long mode guests, and only
 		 * if efer.sce is enabled.
 		 */
-#ifdef X86_64
 		index = __find_msr_index(vcpu, MSR_K6_STAR);
 		if ((index >= 0) && (vcpu->shadow_efer & EFER_SCE))
 			move_msr_up(vcpu, index, save_nmsrs++);
-#endif
 	}
+#endif
 	vcpu->save_nmsrs = save_nmsrs;
 
 #ifdef CONFIG_X86_64

[-- Attachment #4: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #5: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

             reply	other threads:[~2007-05-18  8:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-18  8:30 Daniel Hecken [this message]
     [not found] ` <464D641D.1040402-LcvzS2Pvy/8X0D0ZMPkEVw@public.gmane.org>
2007-05-20  7:34   ` 2 Bugs found for compilation on 32 Bit machine Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=464D641D.1040402@bahntechnik.de \
    --to=dh-lcvzs2pvy/8x0d0zmpkevw@public.gmane.org \
    --cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.