From: Simon Arlott <simon@fire.lp0.eu>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
michal@logix.cz, ioe-lkml@rameria.de
Subject: Re: [PATCH (v2)] crypto: Remove pointless padlock module
Date: Sat, 19 May 2007 20:28:17 +0100 [thread overview]
Message-ID: <464F4FD1.5030308@simon.arlott.org.uk> (raw)
In-Reply-To: <20070518064500.GA16394@gondor.apana.org.au>
On 18/05/07 07:45, Herbert Xu wrote:
> On Sun, Apr 29, 2007 at 09:01:10AM +0100, Simon Arlott wrote:
>> When this is compiled in it is run too early to do anything useful:
>> [ 6.052000] padlock: No VIA PadLock drivers have been loaded.
>> [ 6.052000] padlock: Using VIA PadLock ACE for AES algorithm.
>> [ 6.052000] padlock: Using VIA PadLock ACE for SHA1/SHA256 algorithms.
>>
>> When it's a module it isn't doing anything special, the same functionality
>> can be provided in userspace by "probeall padlock padlock-aes padlock-sha"
>> in modules.conf if it is required.
>
> BTW, I noticed that this prevented CRYPTO_ALGAPI from being marked as m
> since it was selected by CRYPTO_DEV_PADLOCK. So I'm turning it into a
> tristate again.
It should be a bool that doesn't select anything, the AES and SHA modules
will select CRYPTO_ALGAPI. It could also depend on MVIAC3_2 || MVIA_C7
instead of X86_32.
--
Simon Arlott
next prev parent reply other threads:[~2007-05-19 19:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-28 23:40 [PATCH] crypto: Remove pointless padlock module Simon Arlott
2007-04-29 1:59 ` Randy Dunlap
2007-04-29 8:01 ` [PATCH (v2)] " Simon Arlott
2007-05-02 4:50 ` Herbert Xu
2007-05-18 6:45 ` Herbert Xu
2007-05-19 19:28 ` Simon Arlott [this message]
2007-05-20 2:40 ` Dave Jones
2007-05-20 3:15 ` Herbert Xu
2007-05-20 6:54 ` Simon Arlott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464F4FD1.5030308@simon.arlott.org.uk \
--to=simon@fire.lp0.eu \
--cc=herbert@gondor.apana.org.au \
--cc=ioe-lkml@rameria.de \
--cc=linux-kernel@vger.kernel.org \
--cc=michal@logix.cz \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.