From: Jeff Garzik <jeff@garzik.org>
To: Dan Williams <dcbw@redhat.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Florin Malita <fmalita@gmail.com>,
marcelo@kvack.org, linville@redhat.com, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] libertas: skb dereferenced after netif_rx
Date: Sat, 19 May 2007 21:47:00 -0400 [thread overview]
Message-ID: <464FA894.8090008@garzik.org> (raw)
In-Reply-To: <1179622601.9453.4.camel@xo-28-0B-88.localdomain>
Dan Williams wrote:
> On Fri, 2007-05-18 at 14:09 -0400, John W. Linville wrote:
>> On Wed, May 16, 2007 at 05:01:27PM -0400, Florin Malita wrote:
>>> In libertas_process_rxed_packet() and process_rxed_802_11_packet() the
>>> skb is dereferenced after being passed to netif_rx (called from
>>> libertas_upload_rx_packet). Spotted by Coverity (1658, 1659).
>>
>> Relocating the libertas_upload_rx_packet call is fine, but...
>>
>>> Also, libertas_upload_rx_packet() unconditionally returns 0 so the error
>>> check is dead code - might as well take it out.
>> Is this merely an implementation detail? Or an absolute fact?
>> If the former is true, then we should preserve the error
>> checking. If the latter, then we should change the signature of
>> libertas_upload_rx_packet to return void.
>
> According to the comments, netif_rx always succeeds. I think we should
> just change the return type to void since there's nothing else in that
> function that can fail.
According to the implementation, netif_rx() can fail.
Jeff
next prev parent reply other threads:[~2007-05-20 1:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 21:01 [PATCH] libertas: skb dereferenced after netif_rx Florin Malita
2007-05-18 18:09 ` John W. Linville
2007-05-18 18:09 ` John W. Linville
2007-05-18 20:04 ` Florin Malita
2007-05-18 20:04 ` Florin Malita
2007-05-19 5:23 ` Stephen Hemminger
2007-05-19 5:23 ` Stephen Hemminger
2007-05-19 5:37 ` Jeff Garzik
2007-05-19 5:37 ` Jeff Garzik
2007-05-20 0:56 ` Dan Williams
2007-05-20 1:47 ` Jeff Garzik [this message]
2007-05-20 5:20 ` Stephen Hemminger
2007-05-20 5:20 ` Stephen Hemminger
2007-05-20 6:36 ` Jeff Garzik
2007-05-20 7:38 ` David Miller
2007-05-20 7:38 ` David Miller
2007-05-21 14:51 ` Florin Malita
2007-05-21 14:51 ` Florin Malita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464FA894.8090008@garzik.org \
--to=jeff@garzik.org \
--cc=dcbw@redhat.com \
--cc=fmalita@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@redhat.com \
--cc=linville@tuxdriver.com \
--cc=marcelo@kvack.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.