All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
	ath11k@lists.infradead.org
Subject: Re: [PATCH 2/3] ath11k: allow 4 address transmission for mesh packet
Date: Wed, 17 Apr 2019 14:08:30 -0700	[thread overview]
Message-ID: <464f77b1eeafaaa28b3d84c6e7b02bd7@codeaurora.org> (raw)
In-Reply-To: <720f6c2d-bdec-0ec0-a06d-bf628addd23a@phrozen.org>

On 2019-04-17 02:57, John Crispin wrote:
> On 17/04/2019 11:29, Rajkumar Manoharan wrote:
>> diff --git a/drivers/net/wireless/ath/ath11k/mac.c 
>> b/drivers/net/wireless/ath/ath11k/mac.c
>> index b384395bb08c..aea99d9d8d1f 100644
>> --- a/drivers/net/wireless/ath/ath11k/mac.c
>> +++ b/drivers/net/wireless/ath/ath11k/mac.c
>> @@ -2550,6 +2550,17 @@ static int ath11k_sta_state(struct ieee80211_hw 
>> *hw,
>>   				goto exit;
>>   		}
>>   +		if (ieee80211_vif_is_mesh(vif)) {
>> +			ret = ath11k_wmi_set_peer_param(ar, sta->addr,
>> +							arvif->vdev_id,
>> +							WMI_PEER_USE_4ADDR, 1);
>> +			if (ret) {
>> +				ath11k_warn(ar->ab, "failed to STA %pM 4addr capability: %d\n",
>> +						sta->addr, ret);
> 
> Hi,
> 
> looks like the indentation is bad here
> 
John,

I don't see the indentation issue from patch and no warning in 
checkpatch.

-Rajkumar

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2019-04-17 21:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17  9:29 [PATCH 0/3] ath11k: Add Mesh mode support Rajkumar Manoharan
2019-04-17  9:29 ` [PATCH 1/3] ath11k: enable mesh mode Rajkumar Manoharan
2019-04-17  9:56   ` John Crispin
2019-04-17 21:01     ` Rajkumar Manoharan
2019-04-17  9:29 ` [PATCH 2/3] ath11k: allow 4 address transmission for mesh packet Rajkumar Manoharan
2019-04-17  9:57   ` John Crispin
2019-04-17 21:08     ` Rajkumar Manoharan [this message]
2019-04-17  9:29 ` [PATCH 3/3] ath11k: remove unnecessary check for PMF Rajkumar Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=464f77b1eeafaaa28b3d84c6e7b02bd7@codeaurora.org \
    --to=rmanohar@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=john@phrozen.org \
    --cc=pradeepc@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.