From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "hch@lst.de" <hch@lst.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"ming.lei@redhat.com" <ming.lei@redhat.com>
Subject: Re: [PATCH v2] blk-mq: Make blk_mq_get_request() error path less confusing
Date: Fri, 3 Nov 2017 12:34:52 -0600 [thread overview]
Message-ID: <464f9cda-e6c7-e947-e42f-8082a33dbf29@kernel.dk> (raw)
In-Reply-To: <1509733895.2473.30.camel@wdc.com>
On 11/03/2017 12:31 PM, Bart Van Assche wrote:
> On Mon, 2017-10-16 at 16:32 -0700, Bart Van Assche wrote:
>> blk_mq_get_tag() can modify data->ctx. This means that in the
>> error path of blk_mq_get_request() data->ctx should be passed to
>> blk_mq_put_ctx() instead of local_ctx. Note: since blk_mq_put_ctx()
>> ignores its argument, this patch does not change any functionality.
>
> Hello Jens,
>
> Would it be possible to share your opinion about this patch?
Yeah looks fine, I queued it up.
--
Jens Axboe
prev parent reply other threads:[~2017-11-03 18:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 23:32 [PATCH v2] blk-mq: Make blk_mq_get_request() error path less confusing Bart Van Assche
2017-10-17 0:37 ` Ming Lei
2017-10-17 6:35 ` Hannes Reinecke
2017-10-17 6:50 ` Christoph Hellwig
2017-10-17 9:21 ` Johannes Thumshirn
2017-11-03 18:31 ` Bart Van Assche
2017-11-03 18:34 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464f9cda-e6c7-e947-e42f-8082a33dbf29@kernel.dk \
--to=axboe@kernel.dk \
--cc=Bart.VanAssche@wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.