All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: cebbert@redhat.com, netdev@vger.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1
Date: Sun, 20 May 2007 12:03:08 -0700	[thread overview]
Message-ID: <46509B6C.2070604@intel.com> (raw)
In-Reply-To: <E1Hpj4l-0006lF-00@gondolin.me.apana.org.au>

Herbert Xu wrote:
> Kok, Auke <auke-jan.h.kok@intel.com> wrote:
>>> The source file has four extra lines at the top because of a
>>> trivial wireless patch, so 898 in that code is really 894 in
>>> the stock kernel.
>> please shared that code then.
> 
> I've had a look and e1000 is definitely buggy.
> 
> The problem is that you're calling netif_poll_enable on startup.
> This is *wrong*.
> 
> netif_poll_enable can only be called if you've previously called
> netif_poll_disable.  Otherwise a poll might already be in action
> and you may get a crash like this.
> 
> So perhaps you should divide e1000_up into two sections, one that
> is called on both start and restart and another which is only
> called on restart (i.e., after e1000_down).

OK, that would explain the recent frenzy of reports in this matter. That code 
was only recently merged. I will dig into this and get a patch out as soon as I 
can so you can test this.

Thanks Herbert.

Auke

      reply	other threads:[~2007-05-20 19:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-18 22:33 e1000: assertion hit in e1000_clean(), kernel 2.6.21.1 Chuck Ebbert
2007-05-18 23:03 ` Kok, Auke
2007-05-18 23:18   ` Curtis Doty
2007-05-20 10:55   ` Herbert Xu
2007-05-20 19:03     ` Kok, Auke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46509B6C.2070604@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=cebbert@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jesse.brandeburg@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.