Re: [PATCH] __DATE__ & __TIME expansion

[Josh Triplett <josh@freedesktop.org>]

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

Neil Booth wrote:
> Damien Lespiau wrote:-
> 
>> Makes __DATE__expand to a character string literal of
>> the form "Mmm dd yyyy" where the names of the months
>> are the same as those generated by the asctime function,
>> and the first character of dd is a space character if the
>> value is less than 10.
>> Makes __TIME__ expand to a a character string literal of
>> the form "hh:mm:ss" as in the time generated by the
>> asctime function.
>>
>> So says C99.
>>
>> Signed-off-by: Damien Lespiau <damien.lespiau@gmail.com>
> 
> It seems your code could lead to these macros having different
> values in a long compilation, which the standard doesn't permit.

Ah, I didn't know that.  So calling time more than once doesn't just slow down
compilation; it also violates the standard.  I feel better about asking for a
fix to only call time once, now. :)

- Josh Triplett



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]