Neil Brown wrote: > On Monday May 21, gnb@sgi.com wrote: >> In any case I'm happy to do whatever is necessary in the transport >> patchset, but I'd appreciate Neil's guidance on which approach he'd >> prefer before I go in with the scalpel. Neil? > > I cannot immediately see the value in having different debug bits for > the socket transport code and the RDMA transport code. The key > question is "When would you want to see the debugging from one, but > not from the other", and I cannot see when that would be. Almost > certainly if you are testing one transport, you will not be using the > other, so it will not contribute any noise. That's how I did it in the client transport switch. One bit enables debug messages for all transports. > So I suspect we should simply > #define RPCDBG_FACILITY RPCDBG_SVCSOCK That's expedient, but I suggest you rename the flag to something less specific to sockets. > in any server-RDMA specific files, and see how we go.