From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [67.18.166.194] (helo=warp.phpwebhosting.com)
	by canuck.infradead.org with smtp (Exim 4.63 #1 (Red Hat Linux))
	id 1HqQMQ-0007fU-P4
	for linux-mtd@lists.infradead.org; Tue, 22 May 2007 05:09:00 -0400
Message-ID: <4652B321.90006@indefia.com>
Date: Tue, 22 May 2007 12:08:49 +0300
From: Semih Hazar <semih.hazar@indefia.com>
MIME-Version: 1.0
To: vitalywool@gmail.com
Subject: Re: Generic Platform NAND Driver
References: <464D98DF.5020004@indefia.com>
In-Reply-To: <464D98DF.5020004@indefia.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: linux-mtd@lists.infradead.org
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
	<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
	<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

Hi Vitaly,

I couldn't get any replies from the list and I wonder if I'm missing a 
point here.

struct plat_nand_data seems useless to users of this generic nand 
driver, and there is no way of passing user data in mtd structures.

Does that make sense, or am I missing something ?

Also the priv members in platform_nand_chip and platform_nand_ctrl are 
not used in any way. Maybe a better solution would be to utilize these ?

> Hi,
>
> In the new generic platforn NAND driver, line 54;
>
> 	data->chip.priv = &data;
> 	data->mtd.priv = &data->chip;
>
> mtd->priv->priv points to struct plat_nand_data which is defined in the 
> plat_nand.c and never used by it.
> Can we change it so that this priv points to a host specific data, and 
> the helper functions (board specific) can make use of it.
> Below is a suggested patch:
>
> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> index d2365c8..256957b 100644
> --- a/include/linux/mtd/nand.h
> +++ b/include/linux/mtd/nand.h
> @@ -599,10 +599,12 @@ struct platform_nand_ctrl {
>   * struct platform_nand_data - container structure for platform-specific data
>   * @chip:		chip level chip structure
>   * @ctrl:		controller level device structure
> + * @host:		pointer to host specific data structure
>   */
>  struct platform_nand_data {
>  	struct platform_nand_chip	chip;
>  	struct platform_nand_ctrl	ctrl;
> +	void				*host;
>  };
>  
>  /* Some helpers to access the data structures */
> diff --git a/drivers/mtd/nand/plat_nand.c b/drivers/mtd/nand/plat_nand.c
> index cd725fc..1e47ad3 100644
> --- a/drivers/mtd/nand/plat_nand.c
> +++ b/drivers/mtd/nand/plat_nand.c
> @@ -51,7 +51,7 @@ static int __init plat_nand_probe(struct platform_device *pdev)
>  		return -EIO;
>  	}
>  
> -	data->chip.priv = &data;
> +	data->chip.priv = pdata->host;
>  	data->mtd.priv = &data->chip;
>
>  	data->mtd.owner = THIS_MODULE;
>