From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [85.21.88.6] (helo=buildserver.ru.mvista.com)
	by canuck.infradead.org with esmtp (Exim 4.63 #1 (Red Hat Linux))
	id 1HqSOx-00022I-9k
	for linux-mtd@lists.infradead.org; Tue, 22 May 2007 07:19:42 -0400
Message-ID: <4652D1C8.4050305@ru.mvista.com>
Date: Tue, 22 May 2007 15:19:36 +0400
From: "Vladimir A. Barinov" <vbarinov@ru.mvista.com>
MIME-Version: 1.0
To: Semih Hazar <semih.hazar@indefia.com>
Subject: Re: Generic Platform NAND Driver
References: <464D98DF.5020004@indefia.com> <4652B321.90006@indefia.com>
	<4652BC51.9090009@ru.mvista.com> <4652C5EB.7080007@indefia.com>
In-Reply-To: <4652C5EB.7080007@indefia.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: linux-mtd@lists.infradead.org, vitalywool@gmail.com
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
	<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
	<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

Hi Semih,

Semih Hazar wrote:
> Vladimir A. Barinov wrote:
>> You can look at the first (I guess) usage example here:
>> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=4385/2
>>
>>   
>
> +ixdp425_flash_nand_cmd_ctrl(struct mtd_info *mtd, int cmd, unsigned 
> int ctrl)
> +{
> +    struct nand_chip *this = mtd->priv;
> +    int offset = (int)this->priv;
>
> Here offset is read from nand_chip->priv, which actually points to 
> struct plat_nand_data of plat_nand.c
>
> Am I wrong ? 
I agree with you.
And you are right that all things work fine because the 
mtd_info->priv->priv that points to plat_nand_data is not used.

I agree that the line 54 in plat_nand.c should be removed:

-	data->chip.priv = &data;


But does it really usefull to create void * host pointer if it could be 
done in arch code like the above patch does?

Vladimir