Re: [PATCH] ISDN: move card state init to separate function

[Jeff Garzik <jeff@garzik.org>]

Karsten Keil wrote:
> So what is the reason to do this now, does this block some changes in
> other places ? I did not change this code for long time because I know
> that this is a nightmare, the code was grown and grown (supporting more and
> more cards/chipsets) and is really nothing which should be used in future.
> So I would say it maybe better, if it doesn't block anything else, to
> replace HiSax completely with a new modular design. I know that here was not
> so much effort in the past years, but now I got some time to push mISDN
> forward and it looks not so bad to get the first parts ready for mainline
> in June.

ISDN is the biggest chunk of code blocking removal of some deprecated 
PCI interfaces.

If you want to replace the code completely with a newfangled modular 
design, I will gladly step out of the way and let that happen :)  I only 
know what I see right now, which is code that has sat around for a while 
not getting updated to the new PCI API.

Since I do not have any ISDN hardware, my plan was to do equivalent 
transformations of the code.  Each patch just shuffles code, but 
maintains a working state at all time, making it trivial to prove 
(mathematically, or with testing, or with git-bisect) that the code 
continues to work.

So, just tell me which you would prefer.  If you are going to fix all 
this stuff, there is plenty of other stuff on my list to work on. 
Otherwise I will create equivalent-transform patches that take the 
existing code and modify it just enough to be correct for the new PCI API.

	Jeff