Re: [PATCH] Fix compilation warning on 64 bits platforms

[Josh Triplett <josh@freedesktop.org>]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

Damien Lespiau wrote:
>> Al Viro wrote:
>>> Not just glibc; it's in C99.  So yes, I'd say we should use %td here.
> 
> Much better than my ugly cast. I feel stupid to "sign" a one letter patch
> that is not mine, but I guess you expect me to resend it.

Don't worry about it.  I went ahead and made the change:

From 3195f83203cfd6d05cd56829c02c16b5dc5c274d Mon Sep 17 00:00:00 2001
From: Josh Triplett <josh@freedesktop.org>
Date: Tue, 22 May 2007 14:18:28 -0700
Subject: [PATCH] Use %td when printing a ptrdiff_t to avoid problems on 64-bit platforms

Thanks to Damien Lespiau for reporting the problem.

Signed-off-by: Josh Triplett <josh@freedesktop.org>
---
 linearize.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/linearize.c b/linearize.c
index d428d92..c38dd7d 100644
--- a/linearize.c
+++ b/linearize.c
@@ -461,7 +461,7 @@ const char *show_instruction(struct instruction *insn)
 	}
 
 	if (buf >= buffer + sizeof(buffer))
-		die("instruction buffer overflowed %d\n", buf - buffer);
+		die("instruction buffer overflowed %td\n", buf - buffer);
 	do { --buf; } while (*buf == ' ');
 	*++buf = 0;
 	return buffer;

- Josh Triplett


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]