Re: [PATCH 4/5] Fix an __attribute__() parsing error

[Josh Triplett <josh@freedesktop.org>]

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

Ramsay Jones wrote:
> 
> When updating this patch from the 0.3 version, I made the (new) third parameter
> KW_ATTRIBUTE only, rather than (KW_ATTRIBUTE | KW_ASM), since it did not seem
> correct to allow an asm there; is that correct?

Correct; I don't think you can have an asm there.

> The test case for this was abstracted from an example in the "expat.h" header file.
> 
> $cat ape.c
> 
> typedef void (__attribute__((__cdecl__)) *FP)(void *u, const char *n);
> 
> void set_FP(void *cb, FP f);

Applied.  I think you just made a Wine developer very happy.  Michael, this
patch fixes the test case you provided for Wine; I applied your patch for the
new test case.

Thanks, Ramsay!

- Josh Triplett



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]