All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: "Salyzyn, Mark" <mark_salyzyn@adaptec.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: [PATCH] Un-remove aacraid devices
Date: Wed, 23 May 2007 14:50:53 +0200	[thread overview]
Message-ID: <465438AD.8000406@suse.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

Hi Mark,

for some weird reason the aacraid driver insists on presenting all disks
as 'removable' devices. This is gross hackery and causes userspace tools
to not identify these devices as fixed disks, which most evidently they are.

Please apply.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)

[-- Attachment #2: aacraid-unremove-disks --]
[-- Type: text/plain, Size: 722 bytes --]

Make aacraid devices fixed

For some reason the aacraid driver insists on making all devices removable.
This causes userspace tools to not identifying aacraid disks as fixed disks.

Signed-off-by: Hannes Reinecke <hare@suse.de>

diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 1e82c69..24275d8 100644
--- a/drivers/scsi/aacraid/aachba.c
+++ b/drivers/scsi/aacraid/aachba.c
@@ -1843,9 +1843,6 @@ int aac_scsi_cmd(struct scsi_cmnd * scsi
 			} while ((offset += len) < scsicmd->cmnd[13]);
 		}
 
-		/* Do not cache partition table for arrays */
-		scsicmd->device->removable = 1;
-
 		scsicmd->result = DID_OK << 16 | COMMAND_COMPLETE << 8 | SAM_STAT_GOOD;
 		scsicmd->scsi_done(scsicmd);
 

             reply	other threads:[~2007-05-23 12:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-23 12:50 Hannes Reinecke [this message]
2007-05-23 16:35 ` [PATCH] Un-remove aacraid devices Salyzyn, Mark
2007-05-23 17:07   ` James Bottomley
2007-05-23 17:17     ` Salyzyn, Mark
2007-05-23 17:56       ` Salyzyn, Mark
2007-05-23 17:08   ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=465438AD.8000406@suse.de \
    --to=hare@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mark_salyzyn@adaptec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.