Re: [PATCH 2/2] [IPV6] MIP6: Loadable module support for MIPv6.

[Masahide NAKAMURA <nakam@linux-ipv6.org>]

Ingo Oeser wrote:
> nakam@linux-ipv6.org schrieb:
>> From: Masahide NAKAMURA <nakam@linux-ipv6.org>
>>
>> This patch makes MIPv6 loadable module named "mip6".
>>
>> Here is a modprobe.conf(5) example to load it automatically
>> when user application uses XFRM state for MIPv6:
>>
>> alias xfrm-type-10-43 mip6
>> alias xfrm-type-10-60 mip6
> 
> What about  MODULE_ALIAS("xfrm-type-10-60") 
> and MODULE_ALIAS("xfrm-type-10-43") in mip6.c ?
> 
> The aliases in modprobe.conf(5) should not be necessary then.
> 
> If you are really ambitious you can even define a 
> MODULE_ALIAS_XFRM_TYPE macro in include/net/xfrm.h
> simliar to to MODULE_ALIAS_XFRM_MODE.

I prefer to use new macro like XFRM mode to unify XFRM
protocols i.e. esp[46].c, ah[46].c, ipcomp[46].c, and mip6.c
if we care about it. Can I add it as extensional patch
if nobody has a plan to do this yet?


 > Please be sure to discuss CC Herbert Xu then.

# CC-ed.

Regards,

-- 
Masahide NAKAMURA