From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pSj7H-0007E2-So for mharc-grub-devel@gnu.org; Thu, 16 Feb 2023 13:36:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSj7F-00073P-Rg for grub-devel@gnu.org; Thu, 16 Feb 2023 13:36:21 -0500 Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSj7E-0004gJ-25 for grub-devel@gnu.org; Thu, 16 Feb 2023 13:36:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1676572574; i=scdbackup@gmx.net; bh=ng/0fHL1hL78Ji57w7JYMlm+IROHK0i6jE80VOF0NuE=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc:References:In-Reply-To; b=sBpRetELqcMuaBHDtAZzOA2PMx8qdjqNHjP9zGxK49KsknBVHVVw1YaQu9enz2Jdp yAyHepPULkUojdwANQOU6cigBe86qppatcP1xOt7SlR6lrSIHwWP6O/34H50dposSv 59slBW84buK32t7FOzJR7aLA83Xf/VaOA9AJQMdScPErI6vIBOPFI5g5tUTLsU3r93 WSG8KFg/Qxuq1RfV9jqLJr1NuR8GaOhEJp1FaS8JC7NLtHuJ11cwz72C+d1a5fxICi R+D6pJRRoqa7vN2KAbBv+0SQizcPF+ySBv/goVuSMU1dnOy9amHGCUYFe0Xx28CP6X 1dgw+5ZbWh6KQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from scdbackup.webframe.org ([84.179.243.254]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M7b2T-1pU5UB3AbN-0080Vf; Thu, 16 Feb 2023 19:36:14 +0100 Date: Thu, 16 Feb 2023 19:36:40 +0100 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: Re: [PATCH v3] tests: Add pathological iso9660 filesystem tests Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: daniel.kiper@oracle.com,development@efficientek.com References: <20230216115920.224b16cc@crass-HP-ZBook-15-G2> In-Reply-To: <20230216115920.224b16cc@crass-HP-ZBook-15-G2> Message-Id: <46553908148521047429@scdbackup.webframe.org> X-Provags-ID: V03:K1:J9DTio2hH6VXXPHPY4lhcCAInmp2jFau5dKWp6paOt/eTbnb1T5 U0wZkk3Y4Xdb1FNlYwZezBuBjb2Ih7DwP/ypXGtm0FtPDeSV1MZ3eJuRK/n/E8iOg5cOywj 8q7jDV5IzNNO36cbDjyaPFYgb8MAMX5nE+r7nMM+h4fGmqKWDokQeXX6onjJIRjfgqbKnYq rYR/zdRsV/OsKWp3PR6+g== UI-OutboundReport: notjunk:1;M01:P0:bXAzyorZfGM=;J/2NoKGpM0MJA8cxPL9GvYaCRiV F+ekk3inStg4n2l09V4KVDeOuLEDFilmfx/EfLLDmvruO9sGYHsSohLOv/82dyTo2WoAT09tw QYS42xjILepu5OqqFpt8F1LVaC0GCUEpSL4ov4wJPKgGjvh3hYakwvtIr6+8rDwgxnI4gvfAF Icq0+aaDlo0XSbvHB6Af9xo9Zo+RQmA3Q+Ll2l+CUVTl11OLSyNPLdFepp5l7pzIVeeAxpaEN y0q4kRw2lLHo8Y4u8CNnBvn/oIw2bbOZFbZBJenrVfjs4cXPk0VzD9IUUkeHq8vyz/wxR8mfh nL+4jOC42uHvv9dwBL1RekVunOHfMz/habXNdcIKRc/if1vSDV7DF+73YA2Qtx8uK2AS/MhNP 3LS2h+7yjeFefWWFCzjoOOhqv6/EB1Tt41LoSPsxU6aXH8YnTnYEOhEke52OFrBQ92nvSKoCa Mj7zyjFyZzW6UFUo6pOHPPgl7uN6rk5xkNV1PMlATKcAYCzlFheFCZb4KepXy0VDXY2dx7pWc 5MVYWuoBoMhDfYxmE6NWWtzIKjd3x597GE2wa3CKt4t7KZeASdJNPO0qmH+iahLjepEZY8mYS vJTrZkYZ+3VQ111WU038/FMHOcsl1u8Q/cGIRo4EuooafbkeXnJViDRc5fOrxfc+gwOx4CiOm HUj1dwvMuaRl/Gg2ri8/5S8TXxiwuD/zh4TbIlEPrheZ1gUzKJxzcLVKEsKT5CKJcAU/0UyHe ImsKtNXP/oDFgoDBUXcdtq4q84fQkxC15bdr9PgBZjNd7zX98tWtwxwMDSfI1kDizd076xoY7 u3LhrnbR5nt1waxuISkhbSu1txInjQKFfqEBA/+Etm6i3braJBSmnKb4In8Gvk/QTzKMDuP0n 4aWgcH/ELsm6BNTVqlLkJmJPc1FHXxrjbIfISacPPPNvRL3UqGjRZmLBdPcPDcCbvewHSJDWV ArumI7aumUYmC1aQyPMZSuzAU9w= Received-SPF: pass client-ip=212.227.17.21; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2023 18:36:22 -0000 Hi, Glenn Washburn wrote: > > > +echo "Testing for proper recognition of CE loops ... " > Ugh, this should be "echo -n". My make "check" wrote: > > Testing for proper recognition of CE loops ... > > FAIL (iso9660_ce_loop) > > FAIL iso9660_test (exit status: 1) Actually this looks quite ok to me. With echo -n "Testing for proper recognition of CE loops ... " and a disabled loop breaker i get in test-suite.log: Testing for proper recognition of CE loops ... FAIL (iso9660_ce_loop) FAIL iso9660_test (exit status: 1) which looks to me like a newline is missing. The combination of "echo -n" and "..." seems not to occur in the GRUB code= : $ grep -r 'echo -n .*\.\.\.' . | less Some echo without -n have "...": $ grep -r 'echo .*\.\.\.' . | wc -l 65 $ grep -r 'echo .*\.\.\.' tests tests/partmap_test.in:echo "Checking MSDOS partition types..." tests/partmap_test.in:echo "Checking GPT partition types..." tests/partmap_test.in:echo "Checking SUN partition types..." tests/partmap_test.in:echo "Checking APPLE partition types..." tests/partmap_test.in:echo "Checking DVH partition types..." tests/partmap_test.in:echo "Checking AMIGA partition types..." tests/partmap_test.in:echo "Checking DragonFly BSD disklabel64..." $ If "..." as line end is too near to ./configure style, then how about echo "Testing for proper recognition of CE loops:" Have a nice day :) Thomas