From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [PATCH] [xm] Fix vncdisplay for hvm guests Date: Thu, 24 May 2007 10:42:52 -0600 Message-ID: <4655C08C.5080904@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: References: C27B6060.F751%keir@xensource.com List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > > On 16/5/07 00:14, "Jim Fehlig" wrote: > > >> results in '-vncunused' being passed to qemu-dm. There are several >> approaches >> for a fix - this patch defaults vncdisplay to None in xm options. It >> currently defaults to 1 and is always included in the image config >> created by configure_hvm() in tools/python/xen/xm/create.py. In xend >> (tools/python/xen/xend/image.py - parseDeviceModelArgs), vncunused takes >> precedence over vncdisplay. >> > > Looks like it changes vncunused default rather than vncdisplay. Wouldn't the > preferred default be to keep vncunused=1? > Sorry, the wording was a little off in the original post. Right, it does change vncunused to None - not vncdisplay. But the patch was against 3.1.0 and the logic in parseDeviceModelArgs has changed between 3.1.0 and current unstable. In unstable it looks as though vncunused will not be default if it _and_ vncdisplay are not set - which is the case in 3.1.0. Further, I did not verify the default behavior for pv domains if neither vncunused or vncdisplay is set :-/. I will verify behavior of vncunused vs vncdisplay in unstable and repost patch if necessary. Regards, Jim