From: Jeff Garzik <jeff@garzik.org>
To: Jan Altenberg <jan.altenberg@linutronix.de>
Cc: kim.phillips@freescale.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option
Date: Thu, 24 May 2007 17:47:59 -0400 [thread overview]
Message-ID: <4656080F.4080006@garzik.org> (raw)
In-Reply-To: <1179926613.3839.47.camel@bender>
Jan Altenberg wrote:
> ucc_geth has been migrated to use the common phylib code. So lets add a
> 'select PHYLIB' to the UCC_GETH Kconfig entry.
>
> Signed-off-by: Jan Altenberg <jan.altenberg@linutronix.de>
>
> ---
> drivers/net/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6/drivers/net/Kconfig
> ===================================================================
> --- linux-2.6.orig/drivers/net/Kconfig
> +++ linux-2.6/drivers/net/Kconfig
> @@ -2280,6 +2280,7 @@ config GFAR_NAPI
> config UCC_GETH
> tristate "Freescale QE Gigabit Ethernet"
> depends on QUICC_ENGINE
> + select PHYLIB
> select UCC_FAST
Please fix the Kconfig warnings first.
Also, I ask again: WHO IS THE MAINTAINER OF THIS DRIVER?
I am tired of five independent people patching the same driver.
Jeff
next prev parent reply other threads:[~2007-05-24 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 13:23 [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option Jan Altenberg
2007-05-24 0:00 ` Kim Phillips
2007-05-24 21:47 ` Jeff Garzik [this message]
2007-05-25 3:47 ` Li Yang-r58472
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4656080F.4080006@garzik.org \
--to=jeff@garzik.org \
--cc=jan.altenberg@linutronix.de \
--cc=kim.phillips@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.