From: "H. Peter Anvin" <hpa@zytor.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Venki Pallipadi <venkatesh.pallipadi@intel.com>,
Dave Jones <davej@redhat.com>, Len Brown <len.brown@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@suse.de>
Subject: Re: [PATCH] Display Intel Dynamic Acceleration feature in /proc/cpuinfo
Date: Thu, 24 May 2007 15:14:39 -0700 [thread overview]
Message-ID: <46560E4F.2080009@zytor.com> (raw)
In-Reply-To: <20070524150223.41063046.akpm@linux-foundation.org>
Andrew Morton wrote:
>
> I'm not sure I can be bothered repairing all that at present. I think I'll
> go and hide until it becomes somebody else's problem.
>
I'll fix it.
> <looks at hpa's tree>
>
> @@ -23,13 +23,14 @@ static int show_cpuinfo(struct seq_file
> "fpu", "vme", "de", "pse", "tsc", "msr", "pae", "mce",
> "cx8", "apic", NULL, "sep", "mtrr", "pge", "mca", "cmov",
> "pat", "pse36", "pn", "clflush", NULL, "dts", "acpi", "mmx",
> - "fxsr", "sse", "sse2", "ss", "ht", "tm", "ia64", "pbe",
> + "fxsr", "sse", "sse2", "ss", "ht", "tm", "ia64", NULL,
>
> <wonders where pbe went to>
pbe collides with abuse by at least two vendors (AMD and
Cyrix/Centaur/VIA) of this bit for 3DNow. I don't know if that applies
only to the chips that don't support extended CPUID levels, but I'm
fairly sure that we don't handle that correctly in the vendor-specific
handlers.
I guess for now we can just unconditionally disable that bit in those
vendor routines, with a note saying that if there are such chips
supporting PBE then more sophisticated logic needs to be implemented.
-hpa
next prev parent reply other threads:[~2007-05-24 22:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 22:46 [PATCH] Display Intel Dynamic Acceleration feature in /proc/cpuinfo Venki Pallipadi
2007-05-24 20:55 ` Andrew Morton
2007-05-24 21:01 ` Dave Jones
2007-05-24 21:08 ` Andi Kleen
2007-05-24 21:13 ` Venki Pallipadi
2007-05-24 21:25 ` Andi Kleen
2007-05-24 21:28 ` Venki Pallipadi
2007-05-24 21:37 ` Dave Jones
2007-05-24 21:56 ` Andi Kleen
2007-05-24 23:03 ` H. Peter Anvin
2007-05-24 23:13 ` Pallipadi, Venkatesh
2007-05-24 23:23 ` H. Peter Anvin
2007-05-25 0:00 ` Pallipadi, Venkatesh
2007-05-25 0:04 ` H. Peter Anvin
2007-05-30 0:52 ` Venki Pallipadi
2007-05-24 21:10 ` Venki Pallipadi
2007-05-24 22:02 ` Andrew Morton
2007-05-24 22:08 ` Venki Pallipadi
2007-05-24 22:16 ` H. Peter Anvin
2007-05-24 22:14 ` H. Peter Anvin [this message]
2007-05-24 22:41 ` Dave Jones
2007-05-24 22:51 ` H. Peter Anvin
2007-05-24 23:06 ` Dave Jones
2007-05-24 23:11 ` H. Peter Anvin
2007-05-24 23:50 ` Alan Cox
2007-05-24 23:53 ` H. Peter Anvin
2007-05-24 22:27 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46560E4F.2080009@zytor.com \
--to=hpa@zytor.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.