From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965598AbbKDOwQ (ORCPT ); Wed, 4 Nov 2015 09:52:16 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:59363 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932318AbbKDOwO (ORCPT ); Wed, 4 Nov 2015 09:52:14 -0500 From: Arnd Bergmann To: Geliang Tang Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] efirtc: add efi_enabled check in efi_rtc_init Date: Wed, 04 Nov 2015 15:51:46 +0100 Message-ID: <4656157.PeOdPoLWg3@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151104144542.GA3613@bogon> References: <4a37e163f338e9f16c4bae9c819b35afaacbf585.1446475492.git.geliangtang@163.com> <6366386.xsGhxxeFtE@wuerfel> <20151104144542.GA3613@bogon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:KNaISE+dbREdiOB1DWo8/1/5QVSjrM6Af5f3w7retPJ4JKU3lpy Jz/IVGZ2YaN6u0OUYPnQKqmwan1fXRi5WX659vtSLZ746Q/XhRmOpThu1ePt0XCK3EQ82kJ rae6d2b+AsDL6q0u49z2lLdRF2qN+P1BdOKD8fdCRhiZY7uxn2sQcBr19KoxKPVrYkp9GsJ J3BIXhbmoIu4TYyBuf1lQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:BxEd0gyNAJk=:Edtar39++a3QB5VEM0wGXS y+PNpmSQS3F6thtlHpAQZ+cD8c/TrONUhjnAiUo1iX13IG2WkZVhkt9KDm7rytuIbyE59x8ms 6UpdqMPGVLkXuHTDYqm/6//alf183GOQHUYZ3rv0EzJgVCbzhfaYkMNoZzHBVpVB3Ys6gStzD unrjVwiThxrjs5wyIEXdDYlKzJ1JxriMUqefxasQ2u1lHHkbzm9OkMGk7bCamcmrYw/FEeOGz oanvrbRv9DBMj2gdyy5+KOKgpG9Yq3RfviPxp6UazuuT4a1wezCAwRggeMfJeEy3IrgE6qvo+ i2xXO4QFgLzUGYc1I2OBtzr4dy7q/OHF3UlGdFRBztBTzsU1/sp/RrG5VELijFcZVjFv5hRkc 4eAQBkiAW66LwEWDtz+Lc1sQVdKansAGi4Fs2xA5AKhyoSZmDx00vfVLs4oIq8JaEbkjkSYgz Sv7/3G/0V4zrCfN4aeBHTGky1MGimAbVp/oKWpCInwPmmpOtfPCUOCajbLZUR9wdPcjxZF5yU ZEo+Fc2IXkiuEL1GPPTm+rF9OOs3gllPVAqkQVmwZRssZMUTO9h8YyuOAGmK4XLcQCFp2hCyG SSdv+h7+Tnvyo+MzRdIpQH6owXIZJxKVFhEtLeiR1K99L2AvVzC05XWXoX9u/e+Eg/dKKCYJl h3wF/1QbLgvc3yaiPr0zLeWDUJss2SvUlNV9RVldfYzdZ4fr5DF5fVYD70OH3LtcwNEZreQpK ibacIm6nTMvtd0yR Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 04 November 2015 22:45:42 Geliang Tang wrote: > On Mon, Nov 02, 2015 at 04:37:51PM +0100, Arnd Bergmann wrote: > > On Monday 02 November 2015 22:49:01 Geliang Tang wrote: > > > diff --git a/drivers/char/efirtc.c b/drivers/char/efirtc.c > > > index 5323d8c..80058bd 100644 > > > --- a/drivers/char/efirtc.c > > > +++ b/drivers/char/efirtc.c > > > @@ -378,6 +378,9 @@ efi_rtc_init(void) > > > int ret; > > > struct proc_dir_entry *dir; > > > > > > + if (!efi_enabled(EFI_RUNTIME_SERVICES)) > > > + return 0; > > > > > > > Are there any Itanium machines that don't enable runtime services? > > This seems a little redundant otherwise. > > > > Are you trying to run the ancient driver on non-Itanium systems? > > Yes. I did run this driver on a EFI-based X86_64 machine. There should already be a Kconfig dependency that prevents you from doing this. Just use the normal rtc-efi driver instead of the old efirtc driver. Arnd