From: Jeff Garzik <jeff@garzik.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Alan <alan@lxorguk.ukuu.org.uk>
Subject: Re: sil680 MMIO changes moved to branch
Date: Fri, 25 May 2007 00:41:18 -0400 [thread overview]
Message-ID: <465668EE.7020108@garzik.org> (raw)
In-Reply-To: <1180067378.32247.1105.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
> On Fri, 2007-05-25 at 00:26 -0400, Jeff Garzik wrote:
>> Just replace the ata_std_softreset() call with code that does MMIO
>> flushes on a safe register?
>
> Yeah well... if just reading altstatus is enough, I don't see the point
> of doing anything MMIO-dependant or whatever. I can just add reading of
> it after all 3 SRST bit toggles unconditionally.
Sorry, to be clear I would not want to change the core code to bang
AltStatus in the middle of the SRST twiddles...
The core code only fails (in theory) for PATA+MMIO cases, and the
easiest fix should be to read some innocuous vendor-specific register.
That allows the core code to stay unchanged, requiring only two drivers
(pdc and sil680) to be updated with this flushing behavior.
All other discussion of ata_pause() seemed like an unrelated side
discussion, unless I missed something?
Jeff
next prev parent reply other threads:[~2007-05-25 4:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 3:33 sil680 MMIO changes moved to branch Jeff Garzik
2007-05-25 4:11 ` Benjamin Herrenschmidt
2007-05-25 4:26 ` Jeff Garzik
2007-05-25 4:29 ` Benjamin Herrenschmidt
2007-05-25 4:41 ` Jeff Garzik [this message]
2007-05-25 4:57 ` Benjamin Herrenschmidt
2007-05-25 14:11 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465668EE.7020108@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.