Re: [Xenomai-help] Problem with interrupt enabling

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 1742 bytes --]

Johan Borkhuis wrote:
> Jan Kiszka wrote:
>> Johan Borkhuis wrote:
>>  
>>> Hello,
>>>
>>> I am trying to create an RTDM interrupt handler for an external
>>> interrupt. I use a rtdm_irq_request, followed by a rtdm_irq_enable.
>>> This     
>>
>> The rtdm_irq_enable is no longer required with RTDM revision 6 and
>> higher. But that's trunk, it's rev. 5 which still comes with Xenomai
>> 2.3.x. And the enable will also cause no harm with rev. 6.
>>   
> 
> I did see some references to the fact that it is no longer needed in the
> future. I am running 2.3.1, so for the moment I will leave it in.
> 
>>> caused one interrupt to be processed, but subsequent interrupts were
>>> not processed.
>>> After adding an extra rtdm_irq_enable to the ISR the interrupts are
>>> processed. When I look at the other drivers I don't see this. Is this
>>> needed, or is there a bug/feature in the interrupt handling on my
>>> platform?
>>> (I use a MVME3100 with a ppc8540 processor and openPIC interrupt
>>> controller).
>>>     
>>
>> What do you return with your IRQ handler? RTDM_IRQ_HANDLED?
>>   
> Yes, I do return RTDM_IRQ_HANDLED.

OK, then your code should be fine. Which I-pipe patch are you using?

> 
>> That explicit rtdm_irq_enable is not required by design, would rather be
>> a bug on certain platforms (where enable != end IRQ), and indicates that
>> something else is broken, maybe in Xenomai.
>>   
> 
> This driver is ported from a standard Linux driver, and in this driver
> an extra call is also not needed.

Yep. Sounds like a BUG in I-pipe for me (PPC over Xenomai in general is
known to be fine). Wolfgang, Philippe, any ideas if/why we might lack
proper IRQ ending here?

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]