All of lore.kernel.org
 help / color / mirror / Atom feed
From: Szekeres Istvan <szekeres@iii.hu>
To: git@vger.kernel.org
Subject: Bug: git-rebase goofs up \n in commit messages
Date: Fri, 25 May 2007 23:11:26 +0200	[thread overview]
Message-ID: <465750FE.9000406@iii.hu> (raw)

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

Hello,

while playing with git I found the following bug: if a commit message
contains "\n" (as a string, not as a character), git-rebase changes this
string into a literal newline character.

This is how to reproduce it:

mkdir tmp
cd tmp
git init-db
echo xx > xx.txt
git add xx.txt
git commit -m foo
echo xx >> xx.txt
git add xx.txt
git commit -m foo
git branch other 'HEAD^'
git checkout other
echo yy > yy.txt
git add yy.txt
git commit -m 'foo \\n bar'
git log 'HEAD^..'              [1]
git rebase master
git log 'HEAD^..'              [2]

The output of [1] is the following (correctly):

commit 694daa542b83dc1bbd6c070630f73c9a111f6e40
Author: Istvan Szekeres <szekeres@iii.hu>
Date:   Fri May 25 23:09:32 2007 +0200

    foo \n bar


The output of [2] is the following (wrong!):
commit 68ba80d2927d4e21c7a1d1d758f9023dbe063bde
Author: Istvan Szekeres <szekeres@iii.hu>
Date:   Fri May 25 22:58:28 2007 +0200

    foo
     bar
....

I think this is a bug.

Best regards,
Istvan






[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

             reply	other threads:[~2007-05-25 21:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-25 21:11 Szekeres Istvan [this message]
2007-05-26  0:40 ` Bug: git-rebase goofs up \n in commit messages Jeff King
2007-05-26  1:10   ` Herbert Xu
2007-05-26  3:42     ` Jeff King
2007-05-26  3:59       ` Junio C Hamano
2007-05-26  4:59       ` Junio C Hamano
2007-05-26  6:07         ` Jeff King
2007-05-26  6:13           ` Junio C Hamano
2007-05-26  6:19           ` Herbert Xu
2007-05-26  6:27             ` Jeff King
2007-05-26  7:38               ` Herbert Xu
2007-05-26  7:47                 ` Jeff King
2007-05-26  7:47           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=465750FE.9000406@iii.hu \
    --to=szekeres@iii.hu \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.