From: Patrick McHardy <kaber@trash.net>
To: Henrik Nordstrom <henrik@henriknordstrom.net>
Cc: "YU, Haitao" <yuhaitao@tsinghua.org.cn>,
netfilter-devel@lists.netfilter.org
Subject: Re: bugs in ftp conntrack
Date: Sat, 26 May 2007 11:07:32 +0200 [thread overview]
Message-ID: <4657F8D4.8070202@trash.net> (raw)
In-Reply-To: <1180150132.304.21.camel@henriknordstrom.net>
Henrik Nordstrom wrote:
> fre 2007-05-25 klockan 09:10 +0800 skrev YU, Haitao:
>
>
>>I think if it's possible that we don't record the new seqence of too new packets.
>>"Too new packets" means the sequence of the packet is greater than all
>>seq_aft_nl[] values. We just wait until another "port", "227", etc. packet is
>>parsed correctly.
>
>
> The best (save for doing a full TCP stream reassembly or proxying) would
> be to drop such out-of-order packets, relying on the sender to
> retransmit them later.. Might result in quite inefficient
> communication, but will make the protocol parsing behave correctly.
That also sounds like a good idea. We shouldn't see any reordering
in FTP command streams since clients usually wait for an reply before
sending the next command (at least I believe so, or is it always?),
so I'm not too worried about inefficient communication.
That would also allow to find silly bugs in newline sequence number
tracking faster :)
next prev parent reply other threads:[~2007-05-26 9:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 1:10 bugs in ftp conntrack YU, Haitao
2007-05-26 3:28 ` Henrik Nordstrom
2007-05-26 9:07 ` Patrick McHardy [this message]
2007-05-26 9:03 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2007-05-28 3:04 YU, Haitao
2007-05-27 1:35 YU, Haitao
2007-05-22 6:24 YU, Haitao
2007-05-24 18:16 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4657F8D4.8070202@trash.net \
--to=kaber@trash.net \
--cc=henrik@henriknordstrom.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=yuhaitao@tsinghua.org.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.