From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Art Haas <ahaas@airmail.net>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata_piix: fix pio/mwdma programming
Date: Mon, 28 May 2007 09:02:31 -0400 [thread overview]
Message-ID: <465AD2E7.2080600@garzik.org> (raw)
In-Reply-To: <46571A0A.2030305@gmail.com>
Tejun Heo wrote:
> Fix various bugs in pio/mwdma mode programming.
>
> * Control bits in the timing register wasn't cleared properly while
> programming PIO mode.
>
> * MWDMA mode programming cleared the wrong part of control bits.
>
> * MWDMA mode programming cleared udma_mask even when the controller
> doesn't support UDMA.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Art Haas <ahaas@airmail.net>
> ---
> Patch is against libata-dev#upstream. Thanks.
>
> drivers/ata/ata_piix.c | 23 +++++++++++++++++------
> 1 file changed, 17 insertions(+), 6 deletions(-)
applied to #upstream
prev parent reply other threads:[~2007-05-28 13:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 15:18 [PATCH] ata_piix: fix pio/mwdma programming (for testing, don't apply) Tejun Heo
2007-02-02 15:34 ` Sergei Shtylyov
2007-02-02 16:38 ` Jeff Garzik
2007-02-02 16:57 ` Mark Lord
2007-02-02 18:34 ` Sergei Shtylyov
2007-02-02 16:41 ` Tejun Heo
2007-02-02 18:49 ` Alan
2007-02-02 19:04 ` Sergei Shtylyov
2007-02-02 17:42 ` Alan
2007-02-03 1:40 ` Tejun Heo
2007-02-03 20:04 ` Alan
2007-02-04 2:47 ` Tejun Heo
2007-02-02 21:14 ` Art Haas
2007-02-03 2:09 ` Tejun Heo
2007-02-03 14:35 ` Art Haas
2007-02-03 19:47 ` Mark Lord
2007-02-06 9:11 ` Tejun Heo
2007-02-06 16:33 ` Art Haas
2007-02-07 2:53 ` Tejun Heo
2007-02-07 19:35 ` Art Haas
2007-02-07 19:51 ` Mark Lord
2007-02-07 20:37 ` [PATCH] libata: clear TF before IDENTIFYing Tejun Heo
2007-02-08 14:56 ` Mark Lord
2007-02-13 19:38 ` Art Haas
2007-02-15 23:08 ` Jeff Garzik
2007-04-30 18:29 ` [PATCH] Fix pio/mwdma programming on ata_piix.c Art Haas
2007-05-01 3:02 ` Tejun Heo
2007-05-24 19:59 ` Art Haas
2007-05-24 20:55 ` Jeff Garzik
2007-05-24 21:03 ` Tejun Heo
2007-05-25 17:16 ` [PATCH] ata_piix: fix pio/mwdma programming Tejun Heo
2007-05-25 18:05 ` Alan Cox
2007-05-28 13:02 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465AD2E7.2080600@garzik.org \
--to=jeff@garzik.org \
--cc=ahaas@airmail.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.