From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Kalpak Shah <kalpak@clusterfs.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] update ext4-nanosecond-patch comments
Date: Tue, 29 May 2007 13:48:23 +0530 [thread overview]
Message-ID: <465BE1CF.2040304@linux.vnet.ibm.com> (raw)
In-Reply-To: <1180420717.4339.8.camel@garfield>
Kalpak Shah wrote:
> On Tue, 2007-05-29 at 11:18 +0530, Aneesh Kumar K.V wrote:
>> Also can we have a description of why s_{min, want}_extra_isize
>> fields are added in the commit message ?
>
> The i_extra_isize for each inode should ideally be s_want_extra_isize
> after inode expansion. If expansion by s_want_extra_isize is not
> possible, then i_extra_isize must be atleast s_min_extra_isize.
>
>
My point was that the commit message of ext4-nanosecond-patch should
explain the usage scenario for these variables. We may want to move the
commit message of ext4_expand_inode_extra_isize.patch reworded to this.
BTW i also think that adding s_{min, want}_extra_isize can be a separate
patch altogether.
-aneesh
next prev parent reply other threads:[~2007-05-29 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 5:48 [PATCH] update ext4-nanosecond-patch comments Aneesh Kumar K.V
2007-05-29 6:38 ` Kalpak Shah
2007-05-29 8:18 ` Aneesh Kumar K.V [this message]
2007-05-29 11:53 ` Andreas Dilger
2007-05-29 12:27 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465BE1CF.2040304@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=kalpak@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.