From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Takashi Sato <sho@tnes.nec.co.jp>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Online defragmentation
Date: Wed, 30 May 2007 12:34:34 +0530 [thread overview]
Message-ID: <465D2202.60600@linux.vnet.ibm.com> (raw)
Hi Takashi,
I was looking at online defrag code and found that the tmp_inode is
created with tmp_inode->i_nlink equal to zero. Now i am not sure whether
i understand the code correctly, but AFAIU we allocate contiguous block
using this tmp_inode. That means tmp_inode have extent details
corresponding to the blocks. Now we are mapping the file data found in
the original inode to this new blocks. Towards the end we does a iput.
In iput since we have i_nlink as zero it will go ahead and call
generic_delete_inode which will cause these data blocks to be marked
free (right ?)
I haven't tested the defrag code. This came up when i was doing the
online migration. With large file having large number of fragmented
blocks I was getting the below error during the iput of the temporary
inode.
"ext4_free_blocks Freeing blocks not in datazone ...."
I was able to fix that by setting i_nlink = 1 which will cause the
generic_forget_inode to be called
-aneesh
next reply other threads:[~2007-05-30 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 7:04 Aneesh Kumar K.V [this message]
2007-05-30 7:48 ` Online defragmentation Aneesh Kumar K.V
2007-05-31 4:05 ` Takashi Sato
2007-05-30 14:10 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465D2202.60600@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sho@tnes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.