From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: "Dong, Eddie" <eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: guest PTE write emulation
Date: Wed, 30 May 2007 15:25:58 +0300 [thread overview]
Message-ID: <465D6D56.90307@qumranet.com> (raw)
In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A01841631-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Dong, Eddie wrote:
> Avi Kivity wrote:
>
>> On a pte update, npte will always be 1. On a pde update, we won't do
>> anything in mmu_pte_write_new_pte because it doesn't handle
>> pdes. If we
>> extend it to handle pdes, then we need either to modify the
>> new gpde or
>> to have the update take the quadrant into account.
>>
>
> Agree, so we either just skip npte=2 branch or polish it.
> How about following changes?
>
Isn't it all dead code, as gpte[1] will never be used?
Maybe just move the page->role.level test from mmu_pte_write_new_pte()
back to kvm_mmu_pte_write(), so that it's clear that the new data isn't
used for the non-pte case?
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-05-30 12:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 7:59 guest PTE write emulation Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A01840ED9-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-05-29 8:25 ` Avi Kivity
[not found] ` <465BE375.20000-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-29 9:52 ` Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A01840FBB-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-05-29 11:38 ` Avi Kivity
[not found] ` <465C10B1.8090903-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-30 2:33 ` SMP support of MMU Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A0184129A-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-05-30 4:53 ` Avi Kivity
[not found] ` <465D0359.7040908-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-30 5:38 ` Dong, Eddie
2007-05-30 11:40 ` guest PTE write emulation Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A01841631-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-05-30 12:25 ` Avi Kivity [this message]
[not found] ` <465D6D56.90307-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-30 12:48 ` Dong, Eddie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465D6D56.90307@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.