From: Tejun Heo <htejun@gmail.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: gregkh@suse.de, dmitry.torokhov@gmail.com, oneukum@suse.de,
rpurdie@rpsys.net, stern@rowland.harvard.edu, maneesh@in.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] sysfs: implement sysfs flags and SYSFS_FLAG_REMOVED
Date: Wed, 30 May 2007 22:46:13 +0900 [thread overview]
Message-ID: <465D8025.8090102@gmail.com> (raw)
In-Reply-To: <20070530135432.19422e01@gondolin.boeblingen.de.ibm.com>
Cornelia Huck wrote:
> On Tue, 29 May 2007 01:36:26 +0900,
> Tejun Heo <htejun@gmail.com> wrote:
>
>> Rename sysfs_dirent->s_type to s_flags, pack type into lower eight
>> bits and use the rest for flags. sysfs_type() can used to access the
>> type. This patch also implements SYSFS_FLAG_REMOVED which is used to
>> improve sanity check in sysfs_deactivate(). The flag will also be
>> used to make directory entries reclamiable.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>> ---
>> fs/sysfs/dir.c | 37 +++++++++++++++++++++++--------------
>> fs/sysfs/inode.c | 5 +++--
>> fs/sysfs/mount.c | 2 +-
>> fs/sysfs/sysfs.h | 7 ++++++-
>> include/linux/sysfs.h | 4 ++++
>> 5 files changed, 37 insertions(+), 18 deletions(-)
>
> This seems sane, but I'd split this into two patches: One introducing
> sysfs_type(), and one adding SYSFS_FLAG_REMOVED.
Yeap, I would too. :-) I'll split them up on next posting.
--
tejun
next prev parent reply other threads:[~2007-05-30 13:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-28 16:36 [PATCHSET 2.6.22-rc2-mm1 REVIEW] sysfs: make directory dentries/inodes reclaimable Tejun Heo
2007-05-28 16:36 ` [PATCH 1/6] sysfs: implement sysfs flags and SYSFS_FLAG_REMOVED Tejun Heo
2007-05-30 11:54 ` Cornelia Huck
2007-05-30 13:46 ` Tejun Heo [this message]
2007-05-28 16:36 ` [PATCH 4/6] sysfs: use sysfs_lock to protect the sysfs_dirent tree Tejun Heo
2007-05-30 11:33 ` Cornelia Huck
2007-05-30 13:45 ` Tejun Heo
2007-05-28 16:36 ` [PATCH 3/6] sysfs: make kobj point to sysfs_dirent instead of dentry Tejun Heo
2007-05-28 16:36 ` [PATCH 5/6] sysfs: implement sysfs_get_dentry() Tejun Heo
2007-05-28 16:36 ` [PATCH 2/6] sysfs: implement sysfs_find_dirent() and sysfs_get_dirent() Tejun Heo
2007-05-28 16:36 ` [PATCH 6/6] sysfs: make directory dentries and inodes reclaimable Tejun Heo
2007-05-30 10:53 ` [PATCHSET 2.6.22-rc2-mm1 REVIEW] sysfs: make directory dentries/inodes reclaimable Cornelia Huck
-- strict thread matches above, loose matches on Subject: below --
2007-07-01 10:04 [PATCHSET 2/4] libata: implement ata_link, take 4 Tejun Heo
2007-07-01 10:04 ` [PATCH 1/6] sysfs: implement sysfs flags and SYSFS_FLAG_REMOVED Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465D8025.8090102@gmail.com \
--to=htejun@gmail.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=oneukum@suse.de \
--cc=rpurdie@rpsys.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.