All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Andy Whitcroft <apw@shadowen.org>,
	Andi Kleen <andi@firstfloor.org>, Andrew Morton <akpm@osdl.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Joel Schopp <jschopp@austin.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add a trivial patch style checker
Date: Wed, 30 May 2007 08:33:07 -0700	[thread overview]
Message-ID: <465D9933.2000209@oracle.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0705301033470.11140@yvahk01.tjqt.qr>

Jan Engelhardt wrote:
> On May 29 2007 15:36, Randy Dunlap wrote:
>>>>>> +		if($line=~/^\s*[A-Za-z\d_]+:/ and !($line=~/^\s*default:/)){
>>>>>> +			print "Gotos should not be indented\n";
>>>>>> +			print "$herecurr";
>>>>>> +			$clean = 0;
>>>>>> +		}
>>>>> emacs generates one space label in front of a goto label. I wouldn't
>>>>> outlaw this.
>>>> Yep, we also now allow one space something to do with diff -p not
>>>> getting confused...
>>> Not only diff and emacs. At least joe (joe.sf.net) is another editor
> [...]
>> That's just a joe bug then.
>>
>> diff no longer requires a beginning space, at least in the testing
>> that I did it worked with no leading space on a label:.
> 
> But not everyone runs the latest and greatest. diffutils 2.8.7
> takes /^label:/ as a marker for the @@ line.

OK.  What does "marker for the @@ line" mean?

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2007-05-30 15:32 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-27 17:11 [PATCH] add a trivial patch style checker Andy Whitcroft
2007-05-27 17:10 ` Randy Dunlap
2007-05-28 10:48   ` Andy Whitcroft
2007-05-29 15:00   ` Joel Schopp
2007-05-27 17:49 ` Andreas Schwab
2007-05-27 21:49 ` Dave Jones
2007-05-28  0:18 ` Andrew Morton
2007-05-28 12:10   ` Andy Whitcroft
2007-05-28  9:13 ` Sam Ravnborg
2007-05-28  9:45 ` Jan Engelhardt
2007-05-29  9:01   ` Andy Whitcroft
2007-05-29 16:12     ` Joel Schopp
2007-05-29 16:20       ` Julio M. Merino Vidal
2007-05-29 20:00     ` Jan Engelhardt
2007-05-29  1:51 ` Qi Yong
2007-05-29  2:23 ` Andi Kleen
2007-05-29  9:05   ` Andy Whitcroft
2007-05-29 20:22     ` Jan Engelhardt
2007-05-29 22:36       ` Randy Dunlap
2007-05-30  8:34         ` Jan Engelhardt
2007-05-30 15:33           ` Randy Dunlap [this message]
2007-05-30 16:04             ` Jan Engelhardt
2007-05-31 12:07     ` [PATCH] add a trivial patch style checker II Andi Kleen
2007-05-31 19:59       ` Dave Jones
2007-06-01 14:18         ` Andy Whitcroft
2007-05-29 11:53   ` [PATCH] add a trivial patch style checker Heiko Carstens
2007-05-29 13:19     ` Andi Kleen
2007-05-29 14:22       ` Heiko Carstens
2007-05-29 14:58         ` Andi Kleen
2007-05-29 16:43           ` Heiko Carstens
2007-05-29 23:21             ` Andi Kleen
2007-05-29 18:55   ` Andy Whitcroft
2007-05-29 21:07 ` [PATCH] add a trivial patch style checker v2 Andy Whitcroft
2007-05-29 22:42   ` Joel Schopp
2007-06-06 12:40   ` Geert Uytterhoeven
2007-06-06 15:04     ` Dave Jones
2007-06-06 18:35     ` Andy Whitcroft
2007-05-31 19:26 ` [PATCH] add a trivial patch style checker Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=465D9933.2000209@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@osdl.org \
    --cc=andi@firstfloor.org \
    --cc=apw@shadowen.org \
    --cc=jengelh@linux01.gwdg.de \
    --cc=jschopp@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.