From: Jerald Fitzjerald <jfj@freemail.gr>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] missing return
Date: Wed, 30 May 2007 12:16:45 -0700 [thread overview]
Message-ID: <465DCD9D.5090501@freemail.gr> (raw)
In-Reply-To: <7vk5uq2pio.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
>I realize that I've seen this pointed out by somebody already.
>
It was suggested on irc a couple of days ago.
Signed-off-by: Jerald Fitzjerald <jfj@freemail.gr>
---
diff --git a/base85.c b/base85.c
--- a/base85.c
+++ b/base85.c
@@ -66,7 +66,7 @@ int decode_85(char *dst, const char *buf
*/
if (0x03030303 < acc ||
0xffffffff - de < (acc *= 85))
- error("invalid base85 sequence %.5s", buffer-5);
+ return error("invalid base85 sequence %.5s", buffer-5);
acc += de;
say1(" %08x", acc);
prev parent reply other threads:[~2007-05-30 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 12:39 [PATCH] missing return Jerald Fitzjerald
2007-05-30 17:24 ` Junio C Hamano
2007-05-30 19:16 ` Jerald Fitzjerald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465DCD9D.5090501@freemail.gr \
--to=jfj@freemail.gr \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.