All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Venki Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned
Date: Wed, 30 May 2007 21:32:18 +0200	[thread overview]
Message-ID: <465DD142.6040409@trash.net> (raw)
In-Reply-To: <20070530191533.GB3216@linux-os.sc.intel.com>

Venki Pallipadi wrote:
> On Wed, May 30, 2007 at 08:42:32PM +0200, Patrick McHardy wrote:
> 
>>
>>It seems wasteful to add per-packet overhead for tx timeouts, which
>>should be an exception. Do drivers really care about the exact
>>timeout value? Compared to a packet transmission time its incredibly
>>long anyways ..
> 
> 
> I agree. Doing a mod_timer or hrtimer_forward to push forward may add to the
> complexity depending on how often TX happens.
> 
> Are the drivers really worried about exact timeouts here?


Just guessing, but I don't think they are, after all timers can be late.

> Can we use rounding for the timers that are more than a second, at least?


Also sounds reasonable.

  reply	other threads:[~2007-05-30 19:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-29 18:01 [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned Venki Pallipadi
2007-05-30 17:59 ` Andrew Morton
2007-05-30 18:20   ` Stephen Hemminger
2007-05-30 18:42     ` Patrick McHardy
2007-05-30 19:15       ` Venki Pallipadi
2007-05-30 19:32         ` Patrick McHardy [this message]
2007-05-30 19:55       ` David Miller
2007-05-30 20:30         ` Stephen Hemminger
2007-05-30 21:35           ` Venki Pallipadi
2007-05-31 10:36             ` Andi Kleen
2007-05-30 21:10         ` Venki Pallipadi
2007-05-30 22:10         ` Matt Mackall
2007-05-30 22:29           ` David Miller
2007-05-30 22:36             ` Matt Mackall
2007-05-30 23:02               ` David Miller
2007-06-01  4:30 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=465DD142.6040409@trash.net \
    --to=kaber@trash.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.