All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Krivoschekov <dmitry.krivoschekov@gmail.com>
To: Trilok Soni <soni.trilok@gmail.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH 1/1] ARM: OMAP2: TWL4030 RTC driver
Date: Thu, 31 May 2007 14:05:44 +0400	[thread overview]
Message-ID: <465E9DF8.6080806@gmail.com> (raw)
In-Reply-To: <5d5443650705310032m435b4bdcsf9a8efdb9433672f@mail.gmail.com>

Hello Trilok,


thanks for the review.

Trilok Soni wrote:
>>
>> +config RTC_DRV_OMAP2430_TWL4030
>> +       tristate "OMAP243X TWL4030 Real Time Clock"
>> +       depends on RTC_CLASS && TWL4030_CORE
>> +       help
>> +         Support for TWL4030 companion chip internal RTC on OMAP2
>> SDP2430 board
>> +
>
> This driver should work on other boards having TWL4030 chip, so make
> help text more generic please. It is better if you don't have OMAP2430
> in RTC_DRV_OMAP2430_TWL4030

Agreed. We should avoid sticking to a particular board in general.
This issue, as well as codestyle issues you found, will be fixed.


Regards,
Dmitry

      reply	other threads:[~2007-05-31 10:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-31  7:07 [PATCH 1/1] ARM: OMAP2: TWL4030 RTC driver Dmitry Krivoschekov
2007-05-31  7:32 ` Trilok Soni
2007-05-31 10:05   ` Dmitry Krivoschekov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=465E9DF8.6080806@gmail.com \
    --to=dmitry.krivoschekov@gmail.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=soni.trilok@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.