From: Steven Grimm <koreth@midwinter.com>
To: Jonas Fonseca <fonseca@diku.dk>
Cc: git@vger.kernel.org
Subject: Re: [ANNOUNCE] tig 0.7
Date: Thu, 31 May 2007 12:51:13 -0700 [thread overview]
Message-ID: <465F2731.2080707@midwinter.com> (raw)
In-Reply-To: <20070531123808.GA25719@diku.dk>
This doesn't build on OS X out of the box, FYI. It needs the following
tweaks (which break the build on Linux, so I'm not suggesting you apply
this -- looks like you might need a configure script or at least some
conditionals in the Makefile.) The change to tig.c cleans up a compiler
warning, but it does build fine without that change.
---
Makefile | 2 +-
tig.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 57196b0..db5844c 100644
--- a/Makefile
+++ b/Makefile
@@ -19,7 +19,7 @@ endif
RPM_VERSION = $(subst -,.,$(VERSION))
-LDLIBS = -lcurses
+LDLIBS = -lcurses -liconv
CFLAGS = -Wall -O2 '-DVERSION="$(VERSION)"'
DFLAGS = -g -DDEBUG -Werror
PROGS = tig
diff --git a/tig.c b/tig.c
index e918fe6..e94ef4b 100644
--- a/tig.c
+++ b/tig.c
@@ -1913,7 +1913,7 @@ update_view(struct view *view)
line[linelen - 1] = 0;
if (opt_iconv != ICONV_NONE) {
- char *inbuf = line;
+ const char *inbuf = line;
size_t inlen = linelen;
char *outbuf = out_buffer;
--
1.5.2.35.ga334
next prev parent reply other threads:[~2007-05-31 19:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 12:38 [ANNOUNCE] tig 0.7 Jonas Fonseca
2007-05-31 19:51 ` Steven Grimm [this message]
2007-05-31 21:55 ` Jonas Fonseca
2007-06-01 1:29 ` Greg KH
2007-06-03 19:35 ` [PATCH] Add autoconf-based build infrastructure for tig Steven Grimm
2007-06-09 9:31 ` Jonas Fonseca
2007-06-09 17:47 ` Steven Grimm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465F2731.2080707@midwinter.com \
--to=koreth@midwinter.com \
--cc=fonseca@diku.dk \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.