All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Virtualization Mailing List <virtualization@lists.osdl.org>,
	Vivek Goyal <vgoyal@in.ibm.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: another RFC patch: bzImage with ELF payload
Date: Fri, 01 Jun 2007 14:38:24 -0700	[thread overview]
Message-ID: <466091D0.1060803@zytor.com> (raw)
In-Reply-To: <46605E3D.3030009@goop.org>

Jeremy Fitzhardinge wrote:
> OK, here's another go-around.  This patch leaves the bzImage itself
> unmodified, but it changes the payload into an ELF file.  That is, the
> 32-bit decompression/relocation+compressed kernel is now a properly
> formed ELF file.
> 
> One thing that fell out of this is that code32_start end up being a
> pointer to the ELF header rather than an entrypoint.  Rather than
> reproducing Vivek's (?) hack of making the ELF header itself executable,
> I changed the 16-bit code to check for an ELF magic number at
> code32_start and use the e_entry to get the actual entrypoint.  This
> seems like approximately the right way of doing this, but I'm not sure
> how we want to formalize it.  It's certainly easier than trying to
> extract the payload's entry address and copying it to code32_start in
> the boot_params block, and we need a pointer to the ELF file itself anyway.
> 

No, that breaks any boot loader that uses the boot loader hook
mechanism.  That's definitely broken.

Either way, I still believe that this should be done at the other end of
the decompression chain.  Give out the information about *how the kernel
will be executed*, not about the intermediate, transient step.

	-hpa

      parent reply	other threads:[~2007-06-01 21:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-01 17:58 another RFC patch: bzImage with ELF payload Jeremy Fitzhardinge
2007-06-01 18:00 ` Jeremy Fitzhardinge
2007-06-01 19:20   ` Eric W. Biederman
2007-06-01 19:42     ` Jeremy Fitzhardinge
2007-06-01 21:38     ` H. Peter Anvin
2007-06-01 21:38 ` H. Peter Anvin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=466091D0.1060803@zytor.com \
    --to=hpa@zytor.com \
    --cc=ebiederm@xmission.com \
    --cc=jeremy@goop.org \
    --cc=vgoyal@in.ibm.com \
    --cc=virtualization@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.