All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Arlott <simon@fire.lp0.eu>
To: Doug Thompson <norsk5@yahoo.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 23/36] drivers edac Lindent amd76x driver
Date: Sun, 03 Jun 2007 16:17:47 +0100	[thread overview]
Message-ID: <4662DB9B.400@simon.arlott.org.uk> (raw)
In-Reply-To: <616955.99525.qm@web50111.mail.re2.yahoo.com>

On 03/06/07 16:11, Doug Thompson wrote:
> Run this driver through Lindent for cleanup purposes
>  amd76x_edac.c |   54
>  1 file changed, 25 insertions(+), 29 deletions(-)
> --- linux-2.6.22-rc1.orig/drivers/edac/amd76x_edac.c
> +++ linux-2.6.22-rc1/drivers/edac/amd76x_edac.c
> @@ -86,11 +86,9 @@ struct amd76x_dev_info {
>  
>  static const struct amd76x_dev_info amd76x_devs[] = {
>  	[AMD761] = {
> -		.ctl_name = "AMD761"
> -	},
> +		    .ctl_name = "AMD761"},
>  	[AMD762] = {
> -		.ctl_name = "AMD762"
> -	},
> +		    .ctl_name = "AMD762"},
>  };
>  

You're adding a *lot* of spaces...

>From CodingStyle: "Outside of comments, documentation and except in
Kconfig, spaces are never used for indentation".

-- 
Simon Arlott

  reply	other threads:[~2007-06-03 15:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-03 15:11 [PATCH 23/36] drivers edac Lindent amd76x driver Doug Thompson
2007-06-03 15:17 ` Simon Arlott [this message]
2007-06-03 15:22   ` Jan Engelhardt
2007-06-03 15:27   ` Doug Thompson
  -- strict thread matches above, loose matches on Subject: below --
2007-06-03 17:18 Doug Thompson
2007-06-03 14:42 Doug Thompson
2007-06-03  9:34 Doug Thompson
2007-06-03 10:06 ` WANG Cong
2007-06-03  9:33 Doug Thompson
2007-06-03  9:33 Doug Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4662DB9B.400@simon.arlott.org.uk \
    --to=simon@fire.lp0.eu \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=norsk5@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.