From: Jeff Garzik <jeff@garzik.org>
To: Mithlesh Thukral <mithlesh@netxen.com>
Cc: netdev@vger.kernel.org, amitkale@netxen.com,
netxenproj@linsyssoft.com, rob@netxen.com
Subject: Re: [PATCH 3/5] NetXen: Add NETXEN prefix to macros
Date: Sun, 03 Jun 2007 11:50:29 -0400 [thread overview]
Message-ID: <4662E345.3070908@garzik.org> (raw)
In-Reply-To: <200706011115.l51BFahX004752@dut39.unminc.com>
Mithlesh Thukral wrote:
> NetXen: Add NETXEN prefix to a macro
> This patch will add the "NETXEN" prefix to "USER_START" macro.
>
> Signed-off by: Wen Xiong <wenxiong@us.ibm.com>
> Signed-off by: Mithlesh Thukral <mithlesh@netxen.com>
> ---
>
> drivers/net/netxen/netxen_nic.h | 4 ++--
> drivers/net/netxen/netxen_nic_ethtool.c | 2 +-
> drivers/net/netxen/netxen_nic_hw.c | 4 ++--
> drivers/net/netxen/netxen_nic_init.c | 4 ++--
> 4 files changed, 7 insertions(+), 7 deletions(-)
Your patch description is useless. Clearly we know -what- it does,
simply by reading the patch.
But it does not answer the simple question: why? why is this needed in
a bug fix Release Candidate series?
next prev parent reply other threads:[~2007-06-03 15:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 11:15 [PATCH 3/5] NetXen: Add NETXEN prefix to macros Mithlesh Thukral
2007-06-03 15:50 ` Jeff Garzik [this message]
2007-06-04 18:58 ` Andy Gospodarek
2007-06-06 11:07 ` Mithlesh Thukral
2007-06-06 17:52 ` wendy xiong
2007-06-06 18:05 ` Jeff Garzik
2007-06-06 18:33 ` wendy xiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4662E345.3070908@garzik.org \
--to=jeff@garzik.org \
--cc=amitkale@netxen.com \
--cc=mithlesh@netxen.com \
--cc=netdev@vger.kernel.org \
--cc=netxenproj@linsyssoft.com \
--cc=rob@netxen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.