From: Patrick McHardy <kaber@trash.net>
To: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>
Cc: mmohsenz@gmail.com, rusty@rustcorp.com.au,
netfilter-devel@lists.netfilter.org, pablo@netfilter.org,
kadlec@blackhole.kfki.hu
Subject: Re: [RFC][PATCH 0/7]: ct_extend
Date: Mon, 04 Jun 2007 13:58:37 +0200 [thread overview]
Message-ID: <4663FE6D.20005@trash.net> (raw)
In-Reply-To: <200706040045.l540jnhh008964@toshiba.co.jp>
Yasuyuki KOZAKAI wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Fri, 01 Jun 2007 17:33:59 +0200
>
>>How about grabbing nf_conntrack_lock and replacing the entire conntrack
>>structure in this case?
>
>
> It requires very complicated operations. I want to avoid that as possible.
>
> I'm thinking about exporting nf_nat_lock and locks of helpers, and grabbing
> all of them just before reallocating extended area. But I'm not sure it is
> possible because we have to take care about deadlock due to grabbing
> multiple locks in different order.
>
> One more idea is Rusty's comment in the original patch, it replaces array
> of extended area with linked list. But it results in so many small memory
> objects. Hmm...
If it results in one allocation per extension I don't think its a good
idea, one benefit of the array is that we can allocate the room for
multiple extensions at once if we already know its going to be needed.
prev parent reply other threads:[~2007-06-04 11:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 12:00 [RFC][PATCH 0/7]: ct_extend Yasuyuki KOZAKAI
2007-05-08 9:46 ` Patrick McHardy
2007-05-09 11:05 ` Yasuyuki KOZAKAI
[not found] ` <200705091105.l49B5DTu023689@toshiba.co.jp>
2007-05-10 12:34 ` Patrick McHardy
2007-05-11 1:51 ` Yasuyuki KOZAKAI
2007-05-30 23:43 ` Mohammad Mohsenzadeh
2007-05-31 4:38 ` Patrick McHardy
2007-05-31 9:02 ` Yasuyuki KOZAKAI
[not found] ` <200705310902.l4V9212d010654@toshiba.co.jp>
2007-06-01 15:33 ` Patrick McHardy
2007-06-04 0:45 ` Yasuyuki KOZAKAI
[not found] ` <200706040045.l540jnhh008964@toshiba.co.jp>
2007-06-04 11:58 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4663FE6D.20005@trash.net \
--to=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=mmohsenz@gmail.com \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@netfilter.org \
--cc=rusty@rustcorp.com.au \
--cc=yasuyuki.kozakai@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.