From: Albert Lee <albertcc@tw.ibm.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Linux IDE <linux-ide@vger.kernel.org>
Subject: [PATCH 1/3] libata: remove unneeded ata_altstatus() from ata_hsm_qc_complete()
Date: Tue, 05 Jun 2007 11:46:57 +0800 [thread overview]
Message-ID: <4664DCB1.9040908@tw.ibm.com> (raw)
In-Reply-To: <4664DB99.8010202@tw.ibm.com>
Patch 1/3:
In ata_hsm_qc_complete():
Calling ata_altstatus() after the qc completed looks wrong.
Remove it.
Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
---
After checking, it is leftover of ata_pio_block( ) in 2.6.17-rc5 of the following merge:
http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.git;a=commitdiff;h=bb31a8faa270beafcc51a65880c5564c6b718bd6
We can safely remove it.
diff -Nrup 00_libata-dev/drivers/ata/libata-core.c 01_remove_bad_flush/drivers/ata/libata-core.c
--- 00_libata-dev/drivers/ata/libata-core.c 2007-06-01 12:08:21.000000000 +0800
+++ 01_remove_bad_flush/drivers/ata/libata-core.c 2007-06-04 18:10:43.000000000 +0800
@@ -4782,8 +4782,6 @@ static void ata_hsm_qc_complete(struct a
} else
ata_qc_complete(qc);
}
-
- ata_altstatus(ap); /* flush */
}
/**
next prev parent reply other threads:[~2007-06-05 3:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 3:42 [PATCH 0/3] libata: minor pio fixes Albert Lee
2007-06-05 3:46 ` Albert Lee [this message]
2007-06-05 3:50 ` [PATCH 2/3] libata: move ata_altstatus() to pio data xfer functions Albert Lee
2007-06-05 3:53 ` [PATCH 3/3] libata: change the last state of pio read to HSM_ST_IDLE Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4664DCB1.9040908@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=albertl@mail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.