From: Vasily Averin <vvs@sw.ru>
To: Christoph Hellwig <hch@infradead.org>, Vasily Averin <vvs@sw.ru>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devel@openvz.org, linux-ext4@vger.kernel.org,
Stephen Tweedie <sct@redhat.com>,
adilger@clusterfs.com
Subject: Re: [RFC PATCH ext3/ext4] orphan list corruption due bad inode
Date: Tue, 05 Jun 2007 11:31:10 +0400 [thread overview]
Message-ID: <4665113E.5070908@sw.ru> (raw)
In-Reply-To: <20070605061315.GA25760@infradead.org>
Christoph Hellwig wrote:
> On Tue, Jun 05, 2007 at 10:11:12AM +0400, Vasily Averin wrote:
>>>> return d_splice_alias(inode, dentry);
>>>> }
>>> Seems reasonable. So this prevents the bad inodes from getting onto the
>>> orphan list in the first place?
>> make_bad_inode() is called from ext3_read_inode() that is called from iget() only.
>
> Which is artefact of using the read_inode interface. Please switch from
> iget to iget_locked and you can handle this case without ever inserting the
> "bad" inode into the inode hash.
Sorry, I do not understand your proposal. Could you please explain your idea in
more details?
thank you,
Vasily Averin
next prev parent reply other threads:[~2007-06-05 7:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 5:19 [RFC PATCH ext3/ext4] orphan list corruption due bad inode Vasily Averin
2007-06-05 2:03 ` Andrew Morton
2007-06-05 3:52 ` Andreas Dilger
2007-06-05 6:11 ` Vasily Averin
2007-06-05 6:13 ` Christoph Hellwig
2007-06-05 7:31 ` Vasily Averin [this message]
2007-06-05 3:15 ` Eric Sandeen
2007-06-05 6:49 ` Vasily Averin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4665113E.5070908@sw.ru \
--to=vvs@sw.ru \
--cc=adilger@clusterfs.com \
--cc=akpm@linux-foundation.org \
--cc=devel@openvz.org \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.