All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <J.Sixt@eudaptics.com>
To: git@vger.kernel.org
Subject: Re: [PATCH 1/2] git-submodule: move cloning into a separate function
Date: Tue, 05 Jun 2007 12:40:50 +0200	[thread overview]
Message-ID: <46653DB2.997A3ABD@eudaptics.com> (raw)
In-Reply-To: 11810357522478-git-send-email-hjemli@gmail.com

Lars Hjemli wrote:
> +               module_clone "$path" "$url" || exit $?

Minor nit: The idiom that is commonly used in situations like this (see
other git-* shell scripts):

		module_clone "$path" "$url" || exit

because exit without argument uses the code of the last command
executed.

-- Hannes

  reply	other threads:[~2007-06-05 10:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-05  9:29 [PATCH 0/2] git-submodule: make it easier to use alternate urls Lars Hjemli
2007-06-05  9:29 ` [PATCH 1/2] git-submodule: move cloning into a separate function Lars Hjemli
2007-06-05  9:29   ` Lars Hjemli
2007-06-05 10:40     ` Johannes Sixt [this message]
2007-06-05 11:13       ` Lars Hjemli
2007-06-06  8:55         ` Junio C Hamano
2007-06-17 14:38         ` Sven Verdoolaege
2007-06-17 15:56           ` Lars Hjemli
2007-06-05  9:29   ` [PATCH 2/2] git-submodule: clone during update, not during init Lars Hjemli
2007-06-05  9:29     ` Lars Hjemli
2007-06-05 11:18       ` Lars Hjemli
2007-06-06  9:13     ` Lars Hjemli
2007-06-06  9:13   ` [PATCH 1/2] git-submodule: move cloning into a separate function Lars Hjemli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46653DB2.997A3ABD@eudaptics.com \
    --to=j.sixt@eudaptics.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.