From: Chuck Ebbert <cebbert@redhat.com>
To: Masatake YAMATO <jet@gyve.org>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] never called printk statement in ide-taskfile.c::wait_drive_not_busy
Date: Tue, 05 Jun 2007 13:08:26 -0400 [thread overview]
Message-ID: <4665988A.5060902@redhat.com> (raw)
In-Reply-To: <20070605.112124.28713903.jet@gyve.org>
On 06/04/2007 10:21 PM, Masatake YAMATO wrote:
> diff --git a/drivers/ide/ide-taskfile.c b/drivers/ide/ide-taskfile.c
> index 30175c7..5e05311 100644
> --- a/drivers/ide/ide-taskfile.c
> +++ b/drivers/ide/ide-taskfile.c
> @@ -249,7 +249,7 @@ static u8 wait_drive_not_busy(ide_drive_t *drive)
> while (((stat = hwif->INB(IDE_STATUS_REG)) & BUSY_STAT) && retries--)
> udelay(10);
>
> - if (!retries)
> + if (retries < 0)
if (stat & BUSY_STAT)
> printk(KERN_ERR "%s: drive still BUSY!\n", drive->name);
>
> return stat;
next prev parent reply other threads:[~2007-06-05 17:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 2:21 [PATCH] never called printk statement in ide-taskfile.c::wait_drive_not_busy Masatake YAMATO
2007-06-05 17:08 ` Chuck Ebbert [this message]
2007-06-05 17:35 ` Masatake YAMATO
2007-06-15 22:45 ` Bartlomiej Zolnierkiewicz
2007-06-17 18:05 ` Masatake YAMATO
2007-06-21 19:56 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4665988A.5060902@redhat.com \
--to=cebbert@redhat.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=jet@gyve.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.